core (grpc): don't cache per method #1188
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eb7af60 to
b56fcd5
Compare
b56fcd5 to
8faceda
Compare
miguelvelezsa
pushed a commit
that referenced
this pull request
Jul 23, 2025
miguelvelezsa
pushed a commit
that referenced
this pull request
Jul 23, 2025
🤖 I have created a release *beep* *boop* --- ## [2.30.0](googleapis/gax-nodejs@v2.29.7...v2.30.0) (2022-02-23) ### Features * **deps:** Update `google-auth-library` ([#1190](googleapis/gax-nodejs#1190)) ([7981dc5](googleapis/gax-nodejs@7981dc5)) ### Bug Fixes * **deps:** update dependency object-hash to v3 ([#1188](googleapis/gax-nodejs#1188)) ([797e69f](googleapis/gax-nodejs@797e69f)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It turns out we don't need to cache as deeply as we were. The only thing we need to cache is each Service we create. Previously, we connected that cache object with the method being called on it as well, which isn't necessary.