compute: support BackendServices #1159

stephenplusplus · 2016-03-09T20:27:11Z

This implements Backend Services, known here as "services".

To Dos

var service = compute.service('service-name');

service.getHealth({
  name: 'instance-group-name',
  zone: 'us-central1-a'
}, function(err, status) {
  status = [
    {
      ipAddress: '...',
      instance: '...',
      healthState: '...',
      port: '...'
    }
  ]
});

stephenplusplus · 2016-03-11T13:39:45Z

@callmehiphop I'm going to start on the unit tests, but let me know if you catch anything weird with the code.

stephenplusplus · 2016-03-21T14:02:08Z

don't merge lifted!

lib/compute/index.js

+ * @param {object} config - See a
+ *     [BackendService resource](https://cloud.google.com/compute/docs/reference/v1/backendServices#resource).
+ * @param {function=} callback - The callback function.
+ * @param {?error} callback.err - An error returned while making this request.


lib/compute/index.js

+ * @param {string} options.pageToken - A previously-returned page token
+ *     representing part of the larger set of results to view.
+ * @param {function} callback - The callback function.
+ * @param {?error} callback.err - An error returned while making this request.


callmehiphop · 2016-03-21T15:20:03Z

Is there a docs preview for this?

stephenplusplus · 2016-03-21T16:17:47Z

Docs preview up: http://stephenplusplus.github.io/gcloud-node/#/docs/master/compute/service

RE: the missing callback param docs, that was an intentional decision back when we introduced the famous "get or create" overhaul. While having multiple methods to get at the same data can be convenient, the consequence was having to write the exact same documentation in multiple places. That has some hazardous side effects if the code is updated with a docs change local to the source method, the branched methods that reference it would go out of date. The chosen path was simply to have a link back to the source method from the branched methods and let the example do a quick and dirty job of showing what will happen in your callback. If you have any ideas how we can improve on this, open an issue so we can #️⃣ it out!

callmehiphop · 2016-03-21T16:20:18Z

Thanks for the preview! I think we need to add BackendServices to the site navigation via toc.json!

docs/toc.json

      "type": "compute/region"
+    }, {
+      "title": "Service",
+      "type": "compute/service"


callmehiphop · 2016-03-21T16:36:39Z

This might not be the place for it, but are there are any JSDoc tags (aside from link) that would allow us to inherit the documentation from one method to another?

lib/compute/service.js

+ *
+ * @param {string|object} group - The fully-qualified URL of an Instance Group
+ *     resource.
+ * @param {string} - group.name - The name of the Instance Group resource.


stephenplusplus · 2016-03-21T16:40:39Z

Not that I know of. Possibly the callback can be a "type" that we can then reference? I'm not sure if that's real / a hack usage.

compute: support BackendServices

[![WhiteSource Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [mocha](https://mochajs.org/) ([source](https://togithub.com/mochajs/mocha)) | [`^8.0.0` -> `^9.0.0`](https://renovatebot.com/diffs/npm/mocha/8.4.0/9.2.0) | [![age](https://badges.renovateapi.com/packages/npm/mocha/9.2.0/age-slim)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://badges.renovateapi.com/packages/npm/mocha/9.2.0/adoption-slim)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://badges.renovateapi.com/packages/npm/mocha/9.2.0/compatibility-slim/8.4.0)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://badges.renovateapi.com/packages/npm/mocha/9.2.0/confidence-slim/8.4.0)](https://docs.renovatebot.com/merge-confidence/) | | [@types/mocha](https://togithub.com/DefinitelyTyped/DefinitelyTyped) | [`^8.0.0` -> `^9.0.0`](https://renovatebot.com/diffs/npm/@types%2fmocha/8.2.3/9.1.0) | [![age](https://badges.renovateapi.com/packages/npm/@types%2fmocha/9.1.0/age-slim)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://badges.renovateapi.com/packages/npm/@types%2fmocha/9.1.0/adoption-slim)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://badges.renovateapi.com/packages/npm/@types%2fmocha/9.1.0/compatibility-slim/8.2.3)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://badges.renovateapi.com/packages/npm/@types%2fmocha/9.1.0/confidence-slim/8.2.3)](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>mochajs/mocha</summary> ### [`v9.2.0`](https://togithub.com/mochajs/mocha/blob/HEAD/CHANGELOG.md#920--2022-01-24) [Compare Source](https://togithub.com/mochajs/mocha/compare/v9.1.4...v9.2.0) #### 🎉 Enhancements - [#4813](https://togithub.com/mochajs/mocha/issues/4813): Parallel: assign each worker a worker-id ([**@forty**](https://togithub.com/forty)) #### 🔩 Other - [#4818](https://togithub.com/mochajs/mocha/issues/4818): Update production dependencies ([**@juergba**](https://togithub.com/juergba)) ### [`v9.1.4`](https://togithub.com/mochajs/mocha/blob/HEAD/CHANGELOG.md#914--2022-01-14) [Compare Source](https://togithub.com/mochajs/mocha/compare/v9.1.3...v9.1.4) #### 🐛 Fixes - [#4807](https://togithub.com/mochajs/mocha/issues/4807): `import` throws wrong error if loader is used ([**@giltayar**](https://togithub.com/giltayar)) #### 🔩 Other - [#4777](https://togithub.com/mochajs/mocha/issues/4777): Add Node v17 to CI test matrix ([**@outsideris**](https://togithub.com/outsideris)) ### [`v9.1.3`](https://togithub.com/mochajs/mocha/blob/HEAD/CHANGELOG.md#913--2021-10-15) [Compare Source](https://togithub.com/mochajs/mocha/compare/v9.1.2...v9.1.3) #### 🐛 Fixes - [#4769](https://togithub.com/mochajs/mocha/issues/4769): Browser: re-enable `bdd` ES6 style import ([**@juergba**](https://togithub.com/juergba)) #### 🔩 Other - [#4764](https://togithub.com/mochajs/mocha/issues/4764): Revert deprecation of `EVENT_SUITE_ADD_*` events ([**@beatfactor**](https://togithub.com/beatfactor)) ### [`v9.1.2`](https://togithub.com/mochajs/mocha/blob/HEAD/CHANGELOG.md#912--2021-09-25) [Compare Source](https://togithub.com/mochajs/mocha/compare/v9.1.1...v9.1.2) #### 🐛 Fixes - [#4746](https://togithub.com/mochajs/mocha/issues/4746): Browser: stop using all global vars in `browser-entry.js` ([**@PaperStrike**](https://togithub.com/PaperStrike)) #### 🔩 Other - [#4754](https://togithub.com/mochajs/mocha/issues/4754): Remove dependency wide-align ([**@juergba**](https://togithub.com/juergba)) - [#4736](https://togithub.com/mochajs/mocha/issues/4736): ESM: remove code for Node versions <10 ([**@juergba**](https://togithub.com/juergba)) ### [`v9.1.1`](https://togithub.com/mochajs/mocha/blob/HEAD/CHANGELOG.md#911--2021-08-28) [Compare Source](https://togithub.com/mochajs/mocha/compare/v9.1.0...v9.1.1) #### 🐛 Fixes - [#4623](https://togithub.com/mochajs/mocha/issues/4623): `XUNIT` and `JSON` reporter crash in `parallel` mode ([**@curtisman**](https://togithub.com/curtisman)) ### [`v9.1.0`](https://togithub.com/mochajs/mocha/blob/HEAD/CHANGELOG.md#910--2021-08-20) [Compare Source](https://togithub.com/mochajs/mocha/compare/v9.0.3...v9.1.0) #### 🎉 Enhancements - [#4716](https://togithub.com/mochajs/mocha/issues/4716): Add new option `--fail-zero` ([**@juergba**](https://togithub.com/juergba)) - [#4691](https://togithub.com/mochajs/mocha/issues/4691): Add new option `--node-option` ([**@juergba**](https://togithub.com/juergba)) - [#4607](https://togithub.com/mochajs/mocha/issues/4607): Add output option to `JSON` reporter ([**@dorny**](https://togithub.com/dorny)) ### [`v9.0.3`](https://togithub.com/mochajs/mocha/blob/HEAD/CHANGELOG.md#903--2021-07-25) [Compare Source](https://togithub.com/mochajs/mocha/compare/v9.0.2...v9.0.3) #### 🐛 Fixes - [#4702](https://togithub.com/mochajs/mocha/issues/4702): Error rethrow from cwd-relative path while loading `.mocharc.js` ([**@kirill-golovan**](https://togithub.com/kirill-golovan)) - [#4688](https://togithub.com/mochajs/mocha/issues/4688): Usage of custom interface in parallel mode ([**@juergba**](https://togithub.com/juergba)) - [#4687](https://togithub.com/mochajs/mocha/issues/4687): ESM: don't swallow `MODULE_NOT_FOUND` errors in case of `type:module` ([**@giltayar**](https://togithub.com/giltayar)) ### [`v9.0.2`](https://togithub.com/mochajs/mocha/blob/HEAD/CHANGELOG.md#902--2021-07-03) [Compare Source](https://togithub.com/mochajs/mocha/compare/v9.0.1...v9.0.2) #### 🐛 Fixes - [#4668](https://togithub.com/mochajs/mocha/issues/4668): ESM: make `--require <dir>` work with new `import`-first loading ([**@giltayar**](https://togithub.com/giltayar)) #### 🔩 Other - [#4674](https://togithub.com/mochajs/mocha/issues/4674): Update production dependencies ([**@juergba**](https://togithub.com/juergba)) ### [`v9.0.1`](https://togithub.com/mochajs/mocha/blob/HEAD/CHANGELOG.md#901--2021-06-18) [Compare Source](https://togithub.com/mochajs/mocha/compare/v9.0.0...v9.0.1) #### 🔩 Other - [#4657](https://togithub.com/mochajs/mocha/issues/4657): Browser: add separate bundle for modern browsers ([**@juergba**](https://togithub.com/juergba)) We added a separate browser bundle `mocha-es2018.js` in javascript ES2018, as we skipped the transpilation down to ES5. This is an **experimental step towards freezing Mocha's support of IE11**. - [#4653](https://togithub.com/mochajs/mocha/issues/4653): ESM: proper version check in `hasStableEsmImplementation` ([**@alexander-fenster**](https://togithub.com/alexander-fenster)) ### [`v9.0.0`](https://togithub.com/mochajs/mocha/blob/HEAD/CHANGELOG.md#900--2021-06-07) [Compare Source](https://togithub.com/mochajs/mocha/compare/v8.4.0...v9.0.0) #### 💥 Breaking Changes - [#4633](https://togithub.com/mochajs/mocha/issues/4633): **Drop Node.js v10.x support** ([**@juergba**](https://togithub.com/juergba)) - [#4635](https://togithub.com/mochajs/mocha/issues/4635): `import`-first loading of test files ([**@giltayar**](https://togithub.com/giltayar)) **Mocha is going ESM-first!** This means that it will now use ESM `import(test_file)` to load the test files, instead of the CommonJS `require(test_file)`. This is not a problem, as `import` can also load most files that `require` does. In the rare cases where this fails, it will fallback to `require(...)`. This ESM-first approach is the next step in Mocha's ESM migration, and allows ESM loaders to load and transform the test file. - [#4636](https://togithub.com/mochajs/mocha/issues/4636): Remove deprecated `utils.lookupFiles()` ([**@juergba**](https://togithub.com/juergba)) - [#4638](https://togithub.com/mochajs/mocha/issues/4638): Limit the size of `actual`/`expected` for `diff` generation ([**@juergba**](https://togithub.com/juergba)) - [#4389](https://togithub.com/mochajs/mocha/issues/4389): Refactoring: Consuming log-symbols alternate to code for win32 in reporters/base ([**@MoonSupport**](https://togithub.com/MoonSupport)) #### 🎉 Enhancements - [#4640](https://togithub.com/mochajs/mocha/issues/4640): Add new option `--dry-run` ([**@juergba**](https://togithub.com/juergba)) #### 🐛 Fixes - [#4128](https://togithub.com/mochajs/mocha/issues/4128): Fix: control stringification of error message ([**@syeutyu**](https://togithub.com/syeutyu)) #### 🔩 Other - [#4646](https://togithub.com/mochajs/mocha/issues/4646): Deprecate `Runner(suite: Suite, delay: boolean)` signature ([**@juergba**](https://togithub.com/juergba)) - [#4643](https://togithub.com/mochajs/mocha/issues/4643): Update production dependencies ([**@juergba**](https://togithub.com/juergba)) </details> --- ### Configuration 📅 **Schedule**: "after 9am and before 3pm" (UTC). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR is behind base branch, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about these updates again. --- - [ ] If you want to rebase/retry this PR, click this checkbox. --- This PR has been generated by [WhiteSource Renovate](https://renovate.whitesourcesoftware.com). View repository job log [here](https://app.renovatebot.com/dashboard#github/googleapis/gax-nodejs).

stephenplusplus added api: compute Issues related to the Compute Engine API. don't merge labels Mar 9, 2016

googlebot added the cla: yes This human has signed the Contributor License Agreement. label Mar 9, 2016

stephenplusplus force-pushed the spp--1073-backend-services branch from 360dea7 to 0fea456 Compare March 9, 2016 20:27

callmehiphop mentioned this pull request Mar 9, 2016

compute: missing resources #1073

Closed

20 tasks

stephenplusplus force-pushed the spp--1073-backend-services branch from 0fea456 to a8f4282 Compare March 21, 2016 14:01

stephenplusplus removed the don't merge label Mar 21, 2016

stephenplusplus force-pushed the spp--1073-backend-services branch from a8f4282 to 77b5c35 Compare March 21, 2016 14:06

callmehiphop reviewed Mar 21, 2016
View reviewed changes

stephenplusplus force-pushed the spp--1073-backend-services branch from 77b5c35 to 871834e Compare March 21, 2016 15:01

callmehiphop reviewed Mar 21, 2016
View reviewed changes

stephenplusplus force-pushed the spp--1073-backend-services branch 2 times, most recently from 4f79262 to 509c571 Compare March 21, 2016 16:11

stephenplusplus reviewed Mar 21, 2016
View reviewed changes

docs/toc.json

"type": "compute/region"

}, {

"title": "Service",

"type": "compute/service"

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

callmehiphop reviewed Mar 21, 2016
View reviewed changes

compute: support BackendServices

e991601

stephenplusplus force-pushed the spp--1073-backend-services branch from 509c571 to e991601 Compare March 21, 2016 16:41

callmehiphop added a commit that referenced this pull request Mar 21, 2016

Merge pull request #1159 from stephenplusplus/spp--1073-backend-services

1a2b2da

compute: support BackendServices

callmehiphop merged commit 1a2b2da into googleapis:master Mar 21, 2016

compute: support BackendServices #1159

compute: support BackendServices #1159

Uh oh!

Conversation

stephenplusplus commented Mar 9, 2016

To Dos

Uh oh!

stephenplusplus commented Mar 11, 2016

Uh oh!

stephenplusplus commented Mar 21, 2016

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

callmehiphop commented Mar 21, 2016

Uh oh!

stephenplusplus commented Mar 21, 2016

Uh oh!

callmehiphop commented Mar 21, 2016

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

callmehiphop commented Mar 21, 2016

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

stephenplusplus commented Mar 21, 2016

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants