-
Notifications
You must be signed in to change notification settings - Fork 640
common: Avoid using require to read JSON file key #100
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`require` is not working well with relative paths.
Contributor
Author
|
@stephenplusplus, PTAL. |
Contributor
|
LGTM so far. I can take over this one, if you'd like, otherwise feel free to ping again for a final look. |
Contributor
Author
|
Feel free to take over. I will fix key related issues first. |
Contributor
|
Sent a PR to your branch. 📬 |
common: add test for connection with keyFilePath.
rakyll
pushed a commit
that referenced
this pull request
Aug 8, 2014
common: Avoid using require to read JSON file key
chingor13
pushed a commit
that referenced
this pull request
Aug 22, 2022
chingor13
pushed a commit
that referenced
this pull request
Sep 9, 2022
fix: use google-gax v3.3.0 Source-Link: googleapis/synthtool@c73d112 Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-nodejs:latest@sha256:b15a6f06cc06dcffa11e1bebdf1a74b6775a134aac24a0f86f51ddf728eb373e
chingor13
pushed a commit
that referenced
this pull request
Sep 12, 2022
PiperOrigin-RevId: 416140747 Source-Link: googleapis/googleapis@429d35c Source-Link: googleapis/googleapis-gen@9fea20e Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiOWZlYTIwZWRjNjA0MTMyNDg2NDZjNDljMmU1ZDk4NjYzM2VkYjE5MyJ9 Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com> Co-authored-by: Benjamin E. Coe <bencoe@google.com>
chingor13
pushed a commit
that referenced
this pull request
Sep 12, 2022
🤖 I have created a release \*beep\* \*boop\* --- ### [1.2.2](https://www.github.com/googleapis/nodejs-artifact-registry/compare/v1.2.1...v1.2.2) (2021-12-30) ### Bug Fixes * **artifactregistry:** fix resource pattern ID segment name ([#100](https://www.github.com/googleapis/nodejs-artifact-registry/issues/100)) ([27d74c2](https://www.github.com/googleapis/nodejs-artifact-registry/commit/27d74c2d59bf0f9a8985f89b5440ef2fc8e45008)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
chingor13
pushed a commit
that referenced
this pull request
Sep 13, 2022
fix: use google-gax v3.3.0 Source-Link: googleapis/synthtool@c73d112 Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-nodejs:latest@sha256:b15a6f06cc06dcffa11e1bebdf1a74b6775a134aac24a0f86f51ddf728eb373e
chingor13
pushed a commit
that referenced
this pull request
Sep 14, 2022
PiperOrigin-RevId: 416140747 Source-Link: googleapis/googleapis@429d35c Source-Link: googleapis/googleapis-gen@9fea20e Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiOWZlYTIwZWRjNjA0MTMyNDg2NDZjNDljMmU1ZDk4NjYzM2VkYjE5MyJ9 Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com> Co-authored-by: Benjamin E. Coe <bencoe@google.com>
chingor13
pushed a commit
that referenced
this pull request
Sep 14, 2022
🤖 I have created a release \*beep\* \*boop\* --- ### [1.2.2](https://www.github.com/googleapis/nodejs-artifact-registry/compare/v1.2.1...v1.2.2) (2021-12-30) ### Bug Fixes * **artifactregistry:** fix resource pattern ID segment name ([#100](https://www.github.com/googleapis/nodejs-artifact-registry/issues/100)) ([27d74c2](https://www.github.com/googleapis/nodejs-artifact-registry/commit/27d74c2d59bf0f9a8985f89b5440ef2fc8e45008)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Merged
sofisl
pushed a commit
that referenced
this pull request
Oct 12, 2022
This was referenced Oct 12, 2022
sofisl
pushed a commit
that referenced
this pull request
Oct 13, 2022
sofisl
pushed a commit
that referenced
this pull request
Oct 13, 2022
- [ ] Regenerate this pull request now. PiperOrigin-RevId: 392067151 Source-Link: googleapis/googleapis@06345f7 Source-Link: googleapis/googleapis-gen@95882b3
sofisl
pushed a commit
that referenced
this pull request
Oct 13, 2022
🤖 I have created a release \*beep\* \*boop\* --- ## [1.2.0](https://www.github.com/googleapis/nodejs-bigquery-reservation/compare/v1.1.6...v1.2.0) (2021-08-23) ### Features * turns on self-signed JWT feature flag ([#100](https://www.github.com/googleapis/nodejs-bigquery-reservation/issues/100)) ([0047223](https://www.github.com/googleapis/nodejs-bigquery-reservation/commit/004722310ece662732fe60c8941be1b30214ed6d)) ### Bug Fixes * **build:** migrate to using main branch ([#97](https://www.github.com/googleapis/nodejs-bigquery-reservation/issues/97)) ([2e5a332](https://www.github.com/googleapis/nodejs-bigquery-reservation/commit/2e5a332b21067dd73ec6d2b218b87b61b8ebf59e)) * **deps:** google-gax v2.24.1 ([#99](https://www.github.com/googleapis/nodejs-bigquery-reservation/issues/99)) ([3a4cdec](https://www.github.com/googleapis/nodejs-bigquery-reservation/commit/3a4cdec8d028f0d6fd6d8ebc3977c00231b290bb)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
This was referenced Oct 13, 2022
sofisl
pushed a commit
that referenced
this pull request
Oct 13, 2022
Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
sofisl
pushed a commit
that referenced
this pull request
Nov 10, 2022
4 tasks
sofisl
pushed a commit
that referenced
this pull request
Nov 11, 2022
4 tasks
4 tasks
sofisl
pushed a commit
that referenced
this pull request
Nov 16, 2022
sofisl
pushed a commit
that referenced
this pull request
Nov 16, 2022
4 tasks
sofisl
pushed a commit
that referenced
this pull request
Nov 16, 2022
4 tasks
sofisl
pushed a commit
that referenced
this pull request
Nov 17, 2022
This was referenced Nov 17, 2022
sofisl
pushed a commit
that referenced
this pull request
Nov 18, 2022
4 tasks
sofisl
pushed a commit
that referenced
this pull request
Jan 10, 2023
4 tasks
sofisl
pushed a commit
that referenced
this pull request
Jan 17, 2023
sofisl
pushed a commit
that referenced
this pull request
Jan 24, 2023
* codegen: check in synth.py * chore: update google-gax to 0.17.0
sofisl
pushed a commit
that referenced
this pull request
Jan 25, 2023
* codegen: check in synth.py * chore: update google-gax to 0.17.0
sofisl
pushed a commit
that referenced
this pull request
Jan 26, 2023
Co-authored-by: Luke Davis <lukedavis@google.com> Co-authored-by: Benjamin E. Coe <bencoe@google.com>
4 tasks
4 tasks
sofisl
pushed a commit
that referenced
this pull request
Sep 13, 2023
* build: add Kokoro configs for autorelease * build: add Kokoro configs for autorelease * chore: remove CircleCI config
4 tasks
This was referenced Nov 28, 2023
miguelvelezsa
pushed a commit
that referenced
this pull request
Jul 23, 2025
miguelvelezsa
pushed a commit
that referenced
this pull request
Jan 14, 2026
`eslint` was reporting the following error: ``` error Async functions are not supported until Node.js 7.6.0. The configured version range is '>=6.0.0' node/no-unsupported-features/es-syntax ``` This happened because `eslint` has a new `node/no-unsupported-features/es-syntax` that by default reports an error. The error occurs because the samples use async/await, async/await is not available until Node >= 7.6.0, and the samples `package.json` specifies only Node >= 6.0 is required. To fix the linting errors, the `node/no-unsupported-features/es-syntax` was configured to only issue a warning. This was done, instead of updating the `package.json` to specify that Node >= 7.6.0 is required, since the library `@google-cloud/logging-bunyan` library only requires Node >= 6.0.0. It is only if you want to use async/await that Node >= 7.6.0 is required.
This was referenced Jan 14, 2026
GautamSharda
pushed a commit
that referenced
this pull request
Jan 14, 2026
GautamSharda
pushed a commit
that referenced
this pull request
Jan 14, 2026
GautamSharda
pushed a commit
that referenced
this pull request
Jan 15, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
requireis not working well with relative paths.Fixes #95.
Don't merge, unit tests are required.