Skip to content

Conversation

@rakyll
Copy link
Contributor

@rakyll rakyll commented Aug 7, 2014

require is not working well with relative paths.

Fixes #95.

Don't merge, unit tests are required.

`require` is not working well with relative paths.
@rakyll
Copy link
Contributor Author

rakyll commented Aug 7, 2014

@stephenplusplus, PTAL.

@stephenplusplus
Copy link
Contributor

LGTM so far. I can take over this one, if you'd like, otherwise feel free to ping again for a final look.

@rakyll
Copy link
Contributor Author

rakyll commented Aug 7, 2014

Feel free to take over. I will fix key related issues first.

@stephenplusplus
Copy link
Contributor

Sent a PR to your branch. 📬

rakyll pushed a commit that referenced this pull request Aug 8, 2014
common: Avoid using require to read JSON file key
@rakyll rakyll merged commit bf63934 into googleapis:master Aug 8, 2014
chingor13 pushed a commit that referenced this pull request Sep 9, 2022
fix: use google-gax v3.3.0
Source-Link: googleapis/synthtool@c73d112
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-nodejs:latest@sha256:b15a6f06cc06dcffa11e1bebdf1a74b6775a134aac24a0f86f51ddf728eb373e
chingor13 pushed a commit that referenced this pull request Sep 12, 2022
PiperOrigin-RevId: 416140747
Source-Link: googleapis/googleapis@429d35c
Source-Link: googleapis/googleapis-gen@9fea20e
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiOWZlYTIwZWRjNjA0MTMyNDg2NDZjNDljMmU1ZDk4NjYzM2VkYjE5MyJ9
Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
Co-authored-by: Benjamin E. Coe <bencoe@google.com>
chingor13 pushed a commit that referenced this pull request Sep 12, 2022
chingor13 pushed a commit that referenced this pull request Sep 13, 2022
fix: use google-gax v3.3.0
Source-Link: googleapis/synthtool@c73d112
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-nodejs:latest@sha256:b15a6f06cc06dcffa11e1bebdf1a74b6775a134aac24a0f86f51ddf728eb373e
chingor13 pushed a commit that referenced this pull request Sep 14, 2022
PiperOrigin-RevId: 416140747
Source-Link: googleapis/googleapis@429d35c
Source-Link: googleapis/googleapis-gen@9fea20e
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiOWZlYTIwZWRjNjA0MTMyNDg2NDZjNDljMmU1ZDk4NjYzM2VkYjE5MyJ9
Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
Co-authored-by: Benjamin E. Coe <bencoe@google.com>
chingor13 pushed a commit that referenced this pull request Sep 14, 2022
@release-please release-please bot mentioned this pull request Sep 14, 2022
sofisl pushed a commit that referenced this pull request Oct 13, 2022
sofisl pushed a commit that referenced this pull request Oct 13, 2022
- [ ] Regenerate this pull request now.

PiperOrigin-RevId: 392067151

Source-Link: googleapis/googleapis@06345f7

Source-Link: googleapis/googleapis-gen@95882b3
sofisl pushed a commit that referenced this pull request Oct 13, 2022
Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
sofisl pushed a commit that referenced this pull request Nov 10, 2022
sofisl pushed a commit that referenced this pull request Nov 11, 2022
sofisl pushed a commit that referenced this pull request Nov 16, 2022
sofisl pushed a commit that referenced this pull request Nov 17, 2022
sofisl pushed a commit that referenced this pull request Jan 17, 2023
sofisl pushed a commit that referenced this pull request Jan 24, 2023
* codegen: check in synth.py
* chore: update google-gax to 0.17.0
sofisl pushed a commit that referenced this pull request Jan 25, 2023
* codegen: check in synth.py
* chore: update google-gax to 0.17.0
sofisl pushed a commit that referenced this pull request Jan 26, 2023
Co-authored-by: Luke Davis <lukedavis@google.com>
Co-authored-by: Benjamin E. Coe <bencoe@google.com>
sofisl pushed a commit that referenced this pull request Sep 13, 2023
* build: add Kokoro configs for autorelease

* build: add Kokoro configs for autorelease

* chore: remove CircleCI config
miguelvelezsa pushed a commit that referenced this pull request Jan 14, 2026
`eslint` was reporting the following error:
```
error  Async functions are not supported until Node.js 7.6.0. The configured version range is '>=6.0.0'  node/no-unsupported-features/es-syntax
```
This happened because `eslint` has a new `node/no-unsupported-features/es-syntax`
that by default reports an error.

The error occurs because the samples use async/await, async/await is not available
until Node >= 7.6.0, and the samples `package.json` specifies only Node >= 6.0 is required.

To fix the linting errors, the `node/no-unsupported-features/es-syntax` was configured to
only issue a warning.

This was done, instead of updating the `package.json` to specify that Node >= 7.6.0 is
required,   since the library `@google-cloud/logging-bunyan` library only requires
Node >= 6.0.0.  It is only if you want to use async/await that Node >= 7.6.0 is required.
GautamSharda pushed a commit that referenced this pull request Jan 14, 2026
GautamSharda pushed a commit that referenced this pull request Jan 15, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Change to JSON key file breaks using relative paths

2 participants