Skip to content

Upgrade to gax 1.20.0 (and fix bigtable to use the updated apis) #3037

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
garrettjonesgoogle merged 4 commits into from
Mar 16, 2018
Merged

Upgrade to gax 1.20.0 (and fix bigtable to use the updated apis) #3037

garrettjonesgoogle merged 4 commits into from
Mar 16, 2018

Conversation

@igorbernstein2
Copy link

@igorbernstein2 igorbernstein2 commented Mar 14, 2018 •
edited
Loading

Bump to gax 1.20 & api-common (1.5.0). And fix breakage in bigtable (due to updated apis)

Bigtable changes:

  • update settings to use the new context based watchdog
  • update read rows resumption strategy to use the new interface
  • update settings test to: consider unbounded max attempts as sane and to test for watchdog propagation

@igorbernstein2 igorbernstein2 requested a review from pongad as a code owner March 14, 2018 03:13
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Mar 14, 2018
@pongad
Copy link
Contributor

pongad commented Mar 14, 2018

Looks reasonable to me. Out of curiosity: stream resumption is only for server streaming right? Bidi doesn't work with it?

@igorbernstein2
Copy link
Author

igorbernstein2 commented Mar 14, 2018

Yea, sorry :(
I only worked on server streaming use cases to keep focus on the bigtable client. I'd be happy brainstorm how to extend its functionality to bidi.

@pongad
Copy link
Contributor

pongad commented Mar 14, 2018

No worries. I'll think about it as well.

@igorbernstein2 igorbernstein2 changed the title DON'T MERGE Bigtable: Prepare for next gax version Upgrade to gax 1.20.0 (and fix bigtable to use the updated apis) Mar 16, 2018
@igorbernstein2
Copy link
Author

igorbernstein2 commented Mar 16, 2018

gax 1.20.0 has been released. Please merge this when you have a moment. Thanks!

garrettjonesgoogle
garrettjonesgoogle approved these changes Mar 16, 2018
View reviewed changes
Copy link
Member

@garrettjonesgoogle garrettjonesgoogle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@garrettjonesgoogle garrettjonesgoogle merged commit 1847a85 into googleapis:master Mar 16, 2018
@igorbernstein2 igorbernstein2 deleted the gax-upgrade branch March 16, 2018 17:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pongad pongad Awaiting requested review from pongad

1 more reviewer

@garrettjonesgoogle garrettjonesgoogle garrettjonesgoogle approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@igorbernstein2 @pongad @garrettjonesgoogle @googlebot