Skip to content

Adding QueryDocumentSnapshot#2738

Merged
schmidt-sebastian merged 7 commits into
googleapis:masterfrom
FirebasePrivate:mrschmidt-querydocumentsnapshot
Jan 17, 2018
Merged

Adding QueryDocumentSnapshot#2738
schmidt-sebastian merged 7 commits into
googleapis:masterfrom
FirebasePrivate:mrschmidt-querydocumentsnapshot

Conversation

@schmidt-sebastian

@schmidt-sebastian schmidt-sebastian commented Jan 2, 2018

Copy link
Copy Markdown
Contributor

This is based on user feedback and changes the DocumentSnapshot API to return null for non-existing documents (instead of throwing an Exception). Since Queries never return null documents, this PR also introduces QueryDocumentSnapshot, which overrides the DocumentSnapshot methods to be non-nullable.

Addresses b/71489271 and b/69365491

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Jan 2, 2018
pongad
pongad reviewed Jan 3, 2018
View reviewed changes
Comment thread google-cloud-firestore/src/main/java/com/google/cloud/firestore/DocumentSnapshot.java Outdated
/**
* A DocumentSnapshot contains data read from a document in a Firestore database. The data can be
* extracted with the getData or get methods.
* extracted with the getData() or get() methods.

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

Comment thread google-cloud-firestore/src/main/java/com/google/cloud/firestore/DocumentSnapshot.java Outdated
Map<String, Object> decodedFields = new HashMap<>();
for (Map.Entry<String, Value> entry : fields.entrySet()) {
decodedFields.put(entry.getKey(), decodeValue(entry.getValue()));
if (fields != null) {

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

Comment thread google-cloud-firestore/src/main/java/com/google/cloud/firestore/QueryDocumentSnapshot.java
@Override
public Map<String, Object> getData() {
Map<String, Object> result = super.getData();
Preconditions.checkNotNull(result, "Data in a QueryDocumentSnapshot should be non-null");

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

Comment thread google-cloud-firestore/src/main/java/com/google/cloud/firestore/QueryDocumentSnapshot.java
@Override
public <T> T toObject(@Nonnull Class<T> valueType) {
T result = super.toObject(valueType);
Preconditions.checkNotNull(result, "Object in a QueryDocumentSnapshot should be non-null");

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

@pongad

pongad commented Jan 3, 2018

Copy link
Copy Markdown
Contributor

Some stylistic comments. @garrettjonesgoogle PTAL

garrettjonesgoogle
garrettjonesgoogle reviewed Jan 8, 2018
View reviewed changes
Comment thread google-cloud-firestore/src/main/java/com/google/cloud/firestore/DocumentSnapshot.java Outdated
/**
* A DocumentSnapshot contains data read from a document in a Firestore database. The data can be
* extracted with the getData or get methods.
* extracted with the {@code getData()} or {@code get()} methods.

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

Comment thread google-cloud-firestore/src/main/java/com/google/cloud/firestore/QueryDocumentSnapshot.java Outdated
@@ -0,0 +1,87 @@
/*
* Copyright 2017 Google Inc. All Rights Reserved.

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

Comment thread google-cloud-firestore/src/main/java/com/google/cloud/firestore/QueryDocumentSnapshot.java Outdated
import org.threeten.bp.Instant;

/**
* A QueryDocumentSnapshot contains data read from a document in your Firestore database as part of

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

garrettjonesgoogle
garrettjonesgoogle approved these changes Jan 17, 2018
View reviewed changes

@garrettjonesgoogle garrettjonesgoogle left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM after the copyright line is fixed

Comment thread google-cloud-firestore/src/main/java/com/google/cloud/firestore/QueryDocumentSnapshot.java Outdated
@@ -0,0 +1,87 @@
/*
* Copyright 2018 Google Inc. All Rights Reserved.

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

@schmidt-sebastian schmidt-sebastian merged commit 225435d into googleapis:master Jan 17, 2018
chingor13 pushed a commit that referenced this pull request Feb 20, 2026
@renovate-bot
deps: update sdk-platform-java dependencies (#2738)
9556cfe
suztomo pushed a commit that referenced this pull request Mar 9, 2026
@renovate-bot
deps: update dependency com.google.cloud:google-cloud-shared-dependen…
3b56445 
…cies to v3.11.0 (#2738)
chingor13 pushed a commit that referenced this pull request Mar 24, 2026
@zhumin8 @lqiu96
test: destroy httpJsonComplianceClient after tests. (#2738)
5691b7e 
Co-authored-by: Lawrence Qiu <lawrenceqiu@google.com>
chingor13 pushed a commit that referenced this pull request Mar 30, 2026
@renovate-bot @BenWhitehead
deps: update dependency com.google.cloud:sdk-platform-java-config to …
d2c5049 
…v3.36.1 (#2738)

* deps: update dependency com.google.cloud:sdk-platform-java-config to v3.36.1

* chore: add program to regenerate reflect-config.json

* chore: regenerate reflect-config.json for protobuf 1.68.0

---------

Co-authored-by: BenWhitehead <BenWhitehead@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@pongad pongad pongad left review comments

@garrettjonesgoogle garrettjonesgoogle garrettjonesgoogle approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@garrettjonesgoogle garrettjonesgoogle

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@schmidt-sebastian @pongad @garrettjonesgoogle @googlebot