Skip to content

remove ListenableFuture from surface#1599

Merged
pongad merged 4 commits intogoogleapis:masterfrom
pongad:listenable
Feb 9, 2017
Merged

remove ListenableFuture from surface#1599
pongad merged 4 commits intogoogleapis:masterfrom
pongad:listenable

Conversation

@pongad
Copy link
Contributor

@pongad pongad commented Feb 8, 2017 •
edited
Loading

This won't compile yet, since it needs change in gax:
googleapis/gax-java#200

@pongad
DO NOT COMMIT: remove ListenableFuture from surface
6117aff 
This won't compile yet, since it needs change in gax:
googleapis/gax-java#198
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Feb 8, 2017
garrettjonesgoogle
garrettjonesgoogle reviewed Feb 8, 2017
View reviewed changes
google-cloud-pubsub/src/main/java/com/google/cloud/pubsub/spi/v1/MessageReceiver.java Outdated
void receiveMessage(final PubsubMessage message, final SettableFuture<AckReply> response);
interface AckReplyConsumer {
void accept(AckReply ackReply, Throwable t);
}

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

google-cloud-pubsub/src/main/java/com/google/cloud/pubsub/spi/v1/MessageReceiver.java Outdated
* Accepts a reply, sending it to the service.
*
* <p>Both the interface and its method is named after the Java 8's {@code BiConsumer} interface
* to ease migration when we finally move.

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

google-cloud-pubsub/src/main/java/com/google/cloud/pubsub/spi/v1/Publisher.java
return new ListenableFutureDelegate<String>(publishResult);
}

private static class ListenableFutureDelegate<V> extends SimpleForwardingListenableFuture<V>

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

@pongad
Copy link
Contributor Author

pongad commented Feb 9, 2017

@garrettjonesgoogle PTAL

garrettjonesgoogle
garrettjonesgoogle reviewed Feb 9, 2017
View reviewed changes
Copy link
Member

@garrettjonesgoogle garrettjonesgoogle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM after the new GAX is released and the tests pass

google-cloud-pubsub/src/main/java/com/google/cloud/pubsub/spi/v1/AckReplyConsumer.java Outdated
package com.google.cloud.pubsub.spi.v1;

/**
* Used by {@link MessageReceiver}, {@code AckReplyConsumer} accepts an {@link MessageReceiver.AckReply}, sending it to the service.

This comment was marked as spam.

Sign in to view

@garrettjonesgoogle
Copy link
Member

garrettjonesgoogle commented Feb 9, 2017

In the future I think it would be easier to do a PR first against api-client-staging, and then against google-cloud-java.

@garrettjonesgoogle
Copy link
Member

garrettjonesgoogle commented Feb 9, 2017

LGTM

@pongad pongad merged commit f8a7867 into googleapis:master Feb 9, 2017
@pongad pongad deleted the listenable branch February 9, 2017 23:48
@pongad pongad changed the title DO NOT COMMIT: remove ListenableFuture from surface remove ListenableFuture from surface Feb 9, 2017
@coveralls
Copy link

coveralls commented Feb 10, 2017

Coverage Status

Coverage decreased (-0.03%) to 83.424% when pulling 900effe on pongad:listenable into fa0720c on GoogleCloudPlatform:master.

chingor13 pushed a commit that referenced this pull request Jan 22, 2026
@cloud-java-bot @JoeWang1127
chore: Update generation configuration at Sat Sep 28 02:22:38 UTC 2024 (
678eee2 
#1599)

* chore: Update generation configuration at Wed Sep 25 02:24:24 UTC 2024

* update gen script

* chore: generate libraries at Wed Sep 25 23:31:54 UTC 2024

* chore: Update generation configuration at Thu Sep 26 02:23:26 UTC 2024

* chore: Update generation configuration at Fri Sep 27 02:23:56 UTC 2024

* chore: Update generation configuration at Sat Sep 28 02:22:38 UTC 2024

---------

Co-authored-by: Joe Wang <joewa@google.com>
chingor13 pushed a commit that referenced this pull request Feb 12, 2026
@renovate-bot @jinseopkim0
deps: update dependency com.google.cloud:sdk-platform-java-config to …
e021fd8 
…v3.56.1 (#1599)

Co-authored-by: Jin Seop Kim <1007sky@gmail.com>
chingor13 pushed a commit that referenced this pull request Feb 24, 2026
@renovate-bot
chore(deps): update dependency com.google.cloud:google-iam-admin to v…
bc9e057 
…3.50.0 (#1599)
chingor13 pushed a commit that referenced this pull request Mar 12, 2026
@renovate-bot
chore(deps): update dependency com.google.cloud:google-iam-admin to v…
493696c 
…3.50.0 (#1599)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@garrettjonesgoogle garrettjonesgoogle garrettjonesgoogle left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@pongad @garrettjonesgoogle @coveralls @googlebot