Skip to content

DO NOT MERGE: regenerating spi layer - GAX 0.0.22 #1371

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
garrettjonesgoogle wants to merge 1 commit into from
Closed

DO NOT MERGE: regenerating spi layer - GAX 0.0.22 #1371

garrettjonesgoogle wants to merge 1 commit into from

Conversation

@garrettjonesgoogle
Copy link
Member

@garrettjonesgoogle garrettjonesgoogle commented Nov 4, 2016

This is a non-working PR that only includes updates to the SPI
classes. The hand-written layer still needs to be updated.

@garrettjonesgoogle
DO NOT MERGE: regenerating spi layer - GAX 0.0.22
41aee3f 
This is a non-working PR that only includes updates to the SPI
classes. The hand-written layer still needs to be updated.
@garrettjonesgoogle garrettjonesgoogle added the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Nov 4, 2016
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Nov 4, 2016
@garrettjonesgoogle
Copy link
Member Author

garrettjonesgoogle commented Nov 4, 2016

/cc @shinfan @michaelbausor

@mziccard
Copy link
Contributor

mziccard commented Nov 4, 2016

@garrettjonesgoogle thanks! I started working on the integration on this changes into google-cloud-java but I realized that you removed some classes form GAX:

import com.google.api.gax.testing.DownloadableEmulatorRunner;
import com.google.api.gax.testing.GCloudEmulatorRunner;
import com.google.api.gax.testing.LocalServiceHelper;

Those classes were used in our LocalPubSubHelper (which was originally written by you and @shinfan).
I understand that you are using a mocking framework to test autogen code. However, should we add those classes back to GAX or should I implement them in google-cloud-java?

@garrettjonesgoogle
Copy link
Member Author

garrettjonesgoogle commented Nov 4, 2016

The auto-generated testing code already covers everything in the spi layer that the emulator test was covering, so it had become redundant from our perspective. Emulator support has been removed from our testing strategy because it doesn't scale as well. If you still want these tests in google-cloud-java to support the pubsub tests, I would recommend copying them in.

@mziccard mziccard mentioned this pull request Nov 9, 2016
Merged
@mziccard
Copy link
Contributor

mziccard commented Nov 9, 2016

Replaced by #1379

@mziccard mziccard closed this Nov 9, 2016
meltsufin pushed a commit that referenced this pull request Dec 22, 2025
@renovate-bot @gcf-owl-bot
build(deps): update dependency org.apache.maven.plugins:maven-depende…
8223b46 
…ncy-plugin to v3.6.0 (#1371)

* build(deps): update dependency org.apache.maven.plugins:maven-dependency-plugin to v3.6.0

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

---------

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
chingor13 pushed a commit that referenced this pull request Jan 6, 2026
@release-please
chore(main): release 0.131.13-alpha-SNAPSHOT (#1371)
7a3b4c8 
Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

cla: yes This human has signed the Contributor License Agreement. do not merge Indicates a pull request not ready for merge, due to either quality or timing.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@garrettjonesgoogle @mziccard @googlebot