Rename setters/getters/builders for Storage classes to meet proto conventions #1308

mziccard · 2016-10-04T14:55:07Z

This is the first of a series of PRs that update our naming conventions to meet the ones of proto/gRPC/VeneerToolkit.

Changes are:

property(Type property) setters renamed to setProperty(Type property)
property() getters renamed to getProperty()
builder() factory methods renamed to newBuilder()

Previous methods are kept and deprecated for now.

…ventions

coveralls · 2016-10-04T16:04:02Z

Coverage increased (+0.04%) to 84.744% when pulling ac2921b on mziccard:storage-rename into 88344a2 on GoogleCloudPlatform:master.

mziccard · 2016-10-04T20:48:38Z

/cc @lesv

lesv · 2016-10-04T20:53:39Z

Is that a google standard or a vKit thing?

mziccard · 2016-10-04T20:59:06Z

No Google standard that I know of (Guava in fact uses our current style). As per title, this is used in protos and VKIT. In order to be able to expose protos and VKIT classes without breaking Veneer look-and-feel we need to obey to their conventions on this.

lesv

LGTM

lesv · 2016-10-04T21:04:40Z

Sigh - the shorter form works better in IDE's.

coveralls · 2016-10-06T14:33:24Z

Coverage decreased (-0.06%) to 84.652% when pulling 6670b70 on mziccard:storage-rename into 88344a2 on GoogleCloudPlatform:master.

coveralls · 2016-10-06T15:00:36Z

Coverage decreased (-0.06%) to 84.652% when pulling ada166f on mziccard:storage-rename into 88344a2 on GoogleCloudPlatform:master.

mziccard · 2016-10-06T16:15:00Z

@lesv I added 4 commits that do the following:

Avoid deprecating package private methods, just rename them
Update TESTING.md readme
Update storage usage in ITBigQueryTests
Update google-cloud-nio code to use renamed methods

coveralls · 2016-10-06T16:23:06Z

Coverage decreased (-0.06%) to 84.652% when pulling a0b87e0 on mziccard:storage-rename into 88344a2 on GoogleCloudPlatform:master.

lesv

LGTM - I'm reviewing commit by commit.

google-cloud-storage/src/main/java/com/google/cloud/storage/BlobInfo.java

    public abstract Builder setBlobId(BlobId blobId);

-    @Deprecated
-    abstract Builder generatedId(String generatedId);


lesv · 2016-10-06T17:45:26Z

LGTM - I won't be using approve / commit again. Not quite the behavior I was looking for.

BlobInfo seems public not "package private". But I defer to your judgement.

mziccard · 2016-10-06T17:49:03Z

BlobInfo seems public not "package private". But I defer to your judgement.

Yes classes are public but methods I renamed without deprecating them should all be package-private. If that is not the case please point me to the methods so I can fix it.

lesv · 2016-10-06T17:55:39Z

Looked closer, never found a public, so I'm happy.

LGTM

coveralls · 2016-10-11T16:27:14Z

Coverage decreased (-0.06%) to 84.652% when pulling ab64fc6 on mziccard:storage-rename into 88344a2 on GoogleCloudPlatform:master.

lesv · 2016-10-11T20:31:37Z

LGTM

coveralls · 2016-10-20T15:00:51Z

Coverage decreased (-0.03%) to 84.56% when pulling fad6e56 on mziccard:storage-rename into 7bcfe3e on GoogleCloudPlatform:master.

lesv · 2016-10-20T16:41:07Z

LGTM

… v3.5.0 (#1308) [![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [com.google.cloud:google-cloud-asset](https://togithub.com/googleapis/java-asset) | `3.4.1` -> `3.5.0` | [![age](https://badges.renovateapi.com/packages/maven/com.google.cloud:google-cloud-asset/3.5.0/age-slim)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://badges.renovateapi.com/packages/maven/com.google.cloud:google-cloud-asset/3.5.0/adoption-slim)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://badges.renovateapi.com/packages/maven/com.google.cloud:google-cloud-asset/3.5.0/compatibility-slim/3.4.1)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://badges.renovateapi.com/packages/maven/com.google.cloud:google-cloud-asset/3.5.0/confidence-slim/3.4.1)](https://docs.renovatebot.com/merge-confidence/) | --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Renovate will not automatically rebase this PR, because other commits have been found. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, click this checkbox. ⚠ **Warning**: custom changes will be lost. --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://app.renovatebot.com/dashboard#github/googleapis/java-asset).

…1.4 (#1308) [![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [com.google.cloud:libraries-bom](https://cloud.google.com/java/docs/bom) ([source](https://togithub.com/googleapis/java-cloud-bom)) | `26.1.3` -> `26.1.4` | [![age](https://badges.renovateapi.com/packages/maven/com.google.cloud:libraries-bom/26.1.4/age-slim)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://badges.renovateapi.com/packages/maven/com.google.cloud:libraries-bom/26.1.4/adoption-slim)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://badges.renovateapi.com/packages/maven/com.google.cloud:libraries-bom/26.1.4/compatibility-slim/26.1.3)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://badges.renovateapi.com/packages/maven/com.google.cloud:libraries-bom/26.1.4/confidence-slim/26.1.3)](https://docs.renovatebot.com/merge-confidence/) | --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Renovate will not automatically rebase this PR, because other commits have been found. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://app.renovatebot.com/dashboard#github/googleapis/java-automl).

…cies to v3.6.0 (#1308)

mziccard added the api: storage Issues related to the Cloud Storage API. label Oct 4, 2016

googlebot added the cla: yes This human has signed the Contributor License Agreement. label Oct 4, 2016

Rename setters/getters/builders for Storage classes to meet proto con…

ac2921b

…ventions

mziccard force-pushed the storage-rename branch from 9e15c8c to ac2921b Compare October 4, 2016 15:42

lesv approved these changes Oct 4, 2016

View reviewed changes

Favor renaming over deprecation for package-private methods

6670b70

Update TESTING.md to catch RemoteStorageHelper renaming

ada166f

mziccard added 2 commits October 6, 2016 17:45

Update ITBigQueryTest to match Storage renaming

5216672

Update google-cloud-nio to match Storage renaming

a0b87e0

lesv approved these changes Oct 6, 2016

View reviewed changes

lesv reviewed Oct 6, 2016

View reviewed changes

google-cloud-storage/src/main/java/com/google/cloud/storage/BlobInfo.java

public abstract Builder setBlobId(BlobId blobId);

@Deprecated

abstract Builder generatedId(String generatedId);

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

lesv approved these changes Oct 6, 2016

View reviewed changes

Fix RemoteStorageHelper class javadoc

ab64fc6

Make deprecated methods call renamed ones

fad6e56

mziccard force-pushed the storage-rename branch from 4ac2a5f to fad6e56 Compare October 20, 2016 14:23

mziccard merged commit f283895 into googleapis:master Oct 21, 2016

meltsufin pushed a commit that referenced this pull request Dec 22, 2025

deps: update dependency com.google.cloud:google-cloud-shared-dependen…

febcf49

…cies to v3.6.0 (#1308)

Rename setters/getters/builders for Storage classes to meet proto conventions #1308

Rename setters/getters/builders for Storage classes to meet proto conventions #1308

Uh oh!

Conversation

mziccard commented Oct 4, 2016

Uh oh!

coveralls commented Oct 4, 2016

Uh oh!

mziccard commented Oct 4, 2016

Uh oh!

lesv commented Oct 4, 2016

Uh oh!

mziccard commented Oct 4, 2016

Uh oh!

lesv left a comment

Choose a reason for hiding this comment

Uh oh!

lesv commented Oct 4, 2016

Uh oh!

coveralls commented Oct 6, 2016

Uh oh!

coveralls commented Oct 6, 2016

Uh oh!

mziccard commented Oct 6, 2016

Uh oh!

coveralls commented Oct 6, 2016

Uh oh!

lesv left a comment

Choose a reason for hiding this comment

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

lesv commented Oct 6, 2016

Uh oh!

mziccard commented Oct 6, 2016

Uh oh!

lesv commented Oct 6, 2016

Uh oh!

coveralls commented Oct 11, 2016

Uh oh!

lesv commented Oct 11, 2016

Uh oh!

coveralls commented Oct 20, 2016

Uh oh!

lesv commented Oct 20, 2016

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants