Skip to content

Conversation

@mziccard
Copy link
Contributor

@mziccard mziccard commented Oct 3, 2016

This fixes #1300 for good

@mziccard mziccard added the api: datastore Issues related to the Datastore API. label Oct 3, 2016
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.04%) to 84.672% when pulling a6f5b9c on mziccard:gcd-version into b61af33 on GoogleCloudPlatform:master.

@mziccard
Copy link
Contributor Author

mziccard commented Oct 4, 2016

/cc @lesv

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Oct 4, 2016
@lesv
Copy link
Contributor

lesv commented Oct 4, 2016

LGTM - if only folks always kept versions like you expect them. It's likely the emulator will keep the correct scheme, but lots of teams use 0.1.2-1.9.42, 0.2.3-beta, 0.2.3-SNAPSHOT, or 0.2.3-rev172 etc.

@mziccard
Copy link
Contributor Author

mziccard commented Oct 4, 2016

@lesv I was strict on the version format on purpose. I prefer the helper to download its own release version of the emulator rather than possibly using a beta/alpha version already installed via gcloud. I agree this should not happen with emulators.

@mziccard mziccard merged commit 46f808b into googleapis:master Oct 5, 2016
github-actions bot pushed a commit that referenced this pull request Aug 9, 2022
Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
meltsufin pushed a commit that referenced this pull request Dec 22, 2025
Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
chingor13 pushed a commit that referenced this pull request Jan 6, 2026
🤖 I have created a release *beep* *boop*
---


## [0.131.5-alpha](https://togithub.com/googleapis/java-logging-logback/compare/v0.131.4-alpha...v0.131.5-alpha) (2024-04-26)


### Dependencies

* Update actions/checkout action to v4 ([#1301](https://togithub.com/googleapis/java-logging-logback/issues/1301)) ([614fc8f](https://togithub.com/googleapis/java-logging-logback/commit/614fc8fd1e9358652af91ada9ad49b809ac671c0))
* Update actions/github-script action to v7 ([#1299](https://togithub.com/googleapis/java-logging-logback/issues/1299)) ([80d6f4c](https://togithub.com/googleapis/java-logging-logback/commit/80d6f4c2157be25e0270f6e0d7d6bf4e1f571818))
* Update actions/setup-java action to v4 ([#1302](https://togithub.com/googleapis/java-logging-logback/issues/1302)) ([06b124a](https://togithub.com/googleapis/java-logging-logback/commit/06b124a45c61fb150ca928d698466a5a7d4678d3))
* Update dependency com.google.cloud:google-cloud-logging to v3.17.0 ([#1303](https://togithub.com/googleapis/java-logging-logback/issues/1303)) ([7131e07](https://togithub.com/googleapis/java-logging-logback/commit/7131e07ee3eaef7379b1ddb33fadb9f5d89222de))
* Update dependency com.google.cloud:sdk-platform-java-config to v3.29.0 ([#1304](https://togithub.com/googleapis/java-logging-logback/issues/1304)) ([2e87cf9](https://togithub.com/googleapis/java-logging-logback/commit/2e87cf91b170e79731a8318a51bc07f9b2df0d30))

---
This PR was generated with [Release Please](https://togithub.com/googleapis/release-please). See [documentation](https://togithub.com/googleapis/release-please#release-please).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: datastore Issues related to the Datastore API. cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

It is too slow testing Datastore locally when use LocalDatastoreHelper

4 participants