Skip to content

Conversation

@mziccard
Copy link
Contributor

@mziccard mziccard commented Aug 31, 2016

This fixes #1123

@tswast feel free to have a look and comment whether this meets your expectations.

/cc @lesv

@mziccard mziccard added the api: bigquery Issues related to the BigQuery API. label Aug 31, 2016
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Aug 31, 2016
@mziccard mziccard force-pushed the bigquery-project-id branch from 099178b to d6576ce Compare August 31, 2016 14:34
@coveralls
Copy link

Coverage Status

Coverage increased (+0.002%) to 85.197% when pulling d6576ce on mziccard:bigquery-project-id into 7cd60df on GoogleCloudPlatform:master.

@lesv
Copy link
Contributor

lesv commented Aug 31, 2016

LGTM

@Override
public boolean delete(final DatasetId datasetId, DatasetDeleteOption... options) {
public boolean delete(DatasetId datasetId, DatasetDeleteOption... options) {
final DatasetId completeDatasetId = datasetId.setProjectId(options().projectId());

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

@tswast
Copy link
Contributor

tswast commented Aug 31, 2016

LGTM

@mziccard mziccard merged commit 7309be5 into googleapis:master Sep 1, 2016
meltsufin pushed a commit that referenced this pull request Dec 22, 2025
🤖 I have created a release *beep* *boop*
---


### Updating meta-information for bleeding-edge SNAPSHOT release.

---
This PR was generated with [Release Please](https://togithub.com/googleapis/release-please). See [documentation](https://togithub.com/googleapis/release-please#release-please).
chingor13 pushed a commit that referenced this pull request Jan 6, 2026
…ity] (#1217)

* deps: update dependency ch.qos.logback:logback-core to v1.2.13 [security]

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

---------

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: bigquery Issues related to the BigQuery API. cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

BigQuery listTables(DatasetId) does not use project overrided in DatasetId

5 participants