Skip to content

Conversation

@mziccard
Copy link
Contributor

Changes are:

  • Change package names
  • Update LocalDatastoreHelper to use new emulator (cloud-datastore-emulator >= 1.2.0)
  • Enable all tests in DatastoreTest

This fixes #1165 and #1014

- Change package names
- Update LocalDatastoreHelper to use new emulator (cloud-datastore-emulator >= 1.2.0)
- Enable all tests in DatastoreTest
@mziccard mziccard added the api: datastore Issues related to the Datastore API. label Aug 18, 2016
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Aug 18, 2016
@mziccard mziccard added the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Aug 18, 2016
@mziccard
Copy link
Contributor Author

Putting this on hold until the emulator for v1 works on Java7 again.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.02%) to 85.866% when pulling 110c04c on mziccard:update-datastore-v1 into 7c4678d on GoogleCloudPlatform:master.

@mziccard mziccard removed the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Aug 19, 2016
@mziccard
Copy link
Contributor Author

@lesv PTAL

private static final Logger log = Logger.getLogger(LocalDatastoreHelper.class.getName());
private static final String GCD_VERSION = "v1beta3";
private static final String GCD_BUILD = "1.0.1";
private static final String GCD_VERSION = "1.2.0";

This comment was marked as spam.

This comment was marked as spam.

@lesv
Copy link
Contributor

lesv commented Aug 21, 2016

LGTM - my questions appear to be trivial. I would have expected to see a text version of the API change somewhere. GitHub's tools are a bit inadequate to answer my only question, did you miss something? What I've seen looks good. So, unless you think one of your answers would cause me to raise an object, it's ok to merge.

@lesv
Copy link
Contributor

lesv commented Aug 22, 2016

LGTM

@mziccard mziccard merged commit ad5f29b into googleapis:master Aug 23, 2016
github-actions bot pushed a commit that referenced this pull request Jun 23, 2022
🤖 I have created a release *beep* *boop*
---


## [2.2.4](googleapis/java-automl@v2.2.3...v2.2.4) (2022-06-23)


### Dependencies

* update dependency com.google.cloud:google-cloud-shared-dependencies to v2.13.0 ([#1167](googleapis/java-automl#1167)) ([fcc1036](googleapis/java-automl@fcc1036))

---
This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
chingor13 pushed a commit that referenced this pull request Jan 6, 2026
…23.0 (#1169)

* chore(deps): update dependency com.google.cloud:libraries-bom to v26.23.0

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

---------

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: datastore Issues related to the Datastore API. cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Update gcloud-java/datastore to use the v1 API

4 participants