fix: Update vision ITSystemTest to handle deviations in values returned by API #11596
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zhumin8
reviewed
Jun 3, 2025
| for (FaceAnnotation annotation : assertNotEmpty(res, res.getFaceAnnotationsList())) { | ||
| assertThat(annotation.getAngerLikelihood()).isAnyOf(Likelihood.LIKELY, Likelihood.POSSIBLE); | ||
| assertEquals(Likelihood.VERY_UNLIKELY, annotation.getJoyLikelihood()); | ||
| assertEquals(Likelihood.LIKELY, annotation.getSurpriseLikelihood()); |
Contributor
There was a problem hiding this comment.
Do we know if there were any changes to the services that caused this deviation?
Also, seems L306 has similar problems. Recent log of failure in detectFacesGcsTest().
21:07:24:578 [ERROR] Failures:
21:07:24:578 [ERROR] ITSystemTest.detectFacesGcsTest:306 expected: but was:
blakeli0
previously approved these changes
Jun 3, 2025
blakeli0
approved these changes
Jun 3, 2025
lqiu96
pushed a commit
that referenced
this pull request
Jun 10, 2025
lqiu96
pushed a commit
that referenced
this pull request
Jun 10, 2025
lqiu96
pushed a commit
that referenced
this pull request
Jul 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.