Skip to content

Conversation

@lqiu96
Copy link
Member

@lqiu96 lqiu96 commented May 6, 2025

See b/406871794 for more information

@lqiu96 lqiu96 requested a review from a team as a code owner May 6, 2025 18:05
@lqiu96
Copy link
Member Author

lqiu96 commented May 6, 2025

Looks like the sdk-platform-java release removed the added versions to the bom: https://github.com/googleapis/sdk-platform-java/pull/3779/files#diff-378e6e1db0082cbd0b3cc56c4b96df6e8b4f18942e5fd5a2f30d91b1335337af

This version will need to manually set the versions. The next release can remove the hard-coded versions.

@jinseopkim0
Copy link
Contributor

Looks like the sdk-platform-java release removed the added versions to the bom: https://github.com/googleapis/sdk-platform-java/pull/3779/files#diff-378e6e1db0082cbd0b3cc56c4b96df6e8b4f18942e5fd5a2f30d91b1335337af

This version will need to manually set the versions. The next release can remove the hard-coded versions.

Do we know why sdk-platform-java release removed the added versions to the bom?

@lqiu96
Copy link
Member Author

lqiu96 commented May 6, 2025

Looks like the sdk-platform-java release removed the added versions to the bom: https://github.com/googleapis/sdk-platform-java/pull/3779/files#diff-378e6e1db0082cbd0b3cc56c4b96df6e8b4f18942e5fd5a2f30d91b1335337af
This version will need to manually set the versions. The next release can remove the hard-coded versions.

Do we know why sdk-platform-java release removed the added versions to the bom?

I believe it's because release-please ran before hermetic build was able to generate the beta version of the library. I'm guessing that the release please commit removed that deps because there was no equivalent entry in versions.txt file.

@lqiu96 lqiu96 merged commit fa0236b into main May 6, 2025
31 of 32 checks passed
@lqiu96 lqiu96 deleted the generate-iam-v3beta branch May 6, 2025 20:21
lqiu96 added a commit that referenced this pull request Jun 10, 2025
* feat: Generate IAM v3beta Library

* feat: Generate IAM v3beta Library

* chore: generate libraries at Tue May  6 18:43:43 UTC 2025

* chore: Update deps for v3beta

---------

Co-authored-by: cloud-java-bot <cloud-java-bot@google.com>
lqiu96 added a commit that referenced this pull request Jun 10, 2025
* feat: Generate IAM v3beta Library

* feat: Generate IAM v3beta Library

* chore: generate libraries at Tue May  6 18:43:43 UTC 2025

* chore: Update deps for v3beta

---------

Co-authored-by: cloud-java-bot <cloud-java-bot@google.com>
lqiu96 added a commit that referenced this pull request Jul 7, 2025
* feat: Generate IAM v3beta Library

* feat: Generate IAM v3beta Library

* chore: generate libraries at Tue May  6 18:43:43 UTC 2025

* chore: Update deps for v3beta

---------

Co-authored-by: cloud-java-bot <cloud-java-bot@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants