fix: include gax testlib for native image testing #11556
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gax-java [contains native-image configurations](https://github.com/googleapis/sdk-platform-java/blob/main/gax-java/gax/src/test/resources/META-INF/native-image/com.google.api/gax/native-image.properties) that are common to all libraries. This fixes the ongoing nightly failures with messages such as: ``` 1) If it is intended that objects of type 'jdk.proxy4.$Proxy68' are persisted in the image heap, add '--initialize-at-build-time=org.junit.Ignore,java.lang.annotation.Annotation' ``` and ``` 1) If it is intended that objects of type 'org.junit.runners.model.FrameworkField' are persisted in the image heap, add '--initialize-at-build-time=org.junit.runners.model.FrameworkField' ``` The gax testlib [includes these classes](https://github.com/googleapis/sdk-platform-java/blob/main/gax-java/gax/src/test/resources/META-INF/native-image/com.google.api/gax/native-image.properties): ``` Args=--initialize-at-build-time=java.lang.annotation.Annotation,\ org.junit.experimental.categories.Category,\ org.junit.experimental.categories.CategoryValidator,\ org.junit.Ignore,\ org.junit.runner.RunWith,\ org.junit.runners.model.FrameworkField,\ org.junit.validator.AnnotationValidator,\ org.junit.vintage.engine.discovery.FilterableIgnoringRunnerDecorator,\ org.junit.vintage.engine.discovery.IgnoringRunnerDecorator ```
This matches the minimum supported java version by the spotify fmt plugin
meltsufin
approved these changes
May 5, 2025
lqiu96
pushed a commit
that referenced
this pull request
Jun 10, 2025
* fix: include gax testlib for native image testing gax-java [contains native-image configurations](https://github.com/googleapis/sdk-platform-java/blob/main/gax-java/gax/src/test/resources/META-INF/native-image/com.google.api/gax/native-image.properties) that are common to all libraries. This fixes the ongoing nightly failures with messages such as: ``` 1) If it is intended that objects of type 'jdk.proxy4.$Proxy68' are persisted in the image heap, add '--initialize-at-build-time=org.junit.Ignore,java.lang.annotation.Annotation' ``` and ``` 1) If it is intended that objects of type 'org.junit.runners.model.FrameworkField' are persisted in the image heap, add '--initialize-at-build-time=org.junit.runners.model.FrameworkField' ``` The gax testlib [includes these classes](https://github.com/googleapis/sdk-platform-java/blob/main/gax-java/gax/src/test/resources/META-INF/native-image/com.google.api/gax/native-image.properties): ``` Args=--initialize-at-build-time=java.lang.annotation.Annotation,\ org.junit.experimental.categories.Category,\ org.junit.experimental.categories.CategoryValidator,\ org.junit.Ignore,\ org.junit.runner.RunWith,\ org.junit.runners.model.FrameworkField,\ org.junit.validator.AnnotationValidator,\ org.junit.vintage.engine.discovery.FilterableIgnoringRunnerDecorator,\ org.junit.vintage.engine.discovery.IgnoringRunnerDecorator ``` * fix: include gax testlib in specific poms * chore: run lint job on java 17 This matches the minimum supported java version by the spotify fmt plugin
lqiu96
pushed a commit
that referenced
this pull request
Jun 10, 2025
* fix: include gax testlib for native image testing gax-java [contains native-image configurations](https://github.com/googleapis/sdk-platform-java/blob/main/gax-java/gax/src/test/resources/META-INF/native-image/com.google.api/gax/native-image.properties) that are common to all libraries. This fixes the ongoing nightly failures with messages such as: ``` 1) If it is intended that objects of type 'jdk.proxy4.$Proxy68' are persisted in the image heap, add '--initialize-at-build-time=org.junit.Ignore,java.lang.annotation.Annotation' ``` and ``` 1) If it is intended that objects of type 'org.junit.runners.model.FrameworkField' are persisted in the image heap, add '--initialize-at-build-time=org.junit.runners.model.FrameworkField' ``` The gax testlib [includes these classes](https://github.com/googleapis/sdk-platform-java/blob/main/gax-java/gax/src/test/resources/META-INF/native-image/com.google.api/gax/native-image.properties): ``` Args=--initialize-at-build-time=java.lang.annotation.Annotation,\ org.junit.experimental.categories.Category,\ org.junit.experimental.categories.CategoryValidator,\ org.junit.Ignore,\ org.junit.runner.RunWith,\ org.junit.runners.model.FrameworkField,\ org.junit.validator.AnnotationValidator,\ org.junit.vintage.engine.discovery.FilterableIgnoringRunnerDecorator,\ org.junit.vintage.engine.discovery.IgnoringRunnerDecorator ``` * fix: include gax testlib in specific poms * chore: run lint job on java 17 This matches the minimum supported java version by the spotify fmt plugin
lqiu96
pushed a commit
that referenced
this pull request
Jul 7, 2025
* fix: include gax testlib for native image testing gax-java [contains native-image configurations](https://github.com/googleapis/sdk-platform-java/blob/main/gax-java/gax/src/test/resources/META-INF/native-image/com.google.api/gax/native-image.properties) that are common to all libraries. This fixes the ongoing nightly failures with messages such as: ``` 1) If it is intended that objects of type 'jdk.proxy4.$Proxy68' are persisted in the image heap, add '--initialize-at-build-time=org.junit.Ignore,java.lang.annotation.Annotation' ``` and ``` 1) If it is intended that objects of type 'org.junit.runners.model.FrameworkField' are persisted in the image heap, add '--initialize-at-build-time=org.junit.runners.model.FrameworkField' ``` The gax testlib [includes these classes](https://github.com/googleapis/sdk-platform-java/blob/main/gax-java/gax/src/test/resources/META-INF/native-image/com.google.api/gax/native-image.properties): ``` Args=--initialize-at-build-time=java.lang.annotation.Annotation,\ org.junit.experimental.categories.Category,\ org.junit.experimental.categories.CategoryValidator,\ org.junit.Ignore,\ org.junit.runner.RunWith,\ org.junit.runners.model.FrameworkField,\ org.junit.validator.AnnotationValidator,\ org.junit.vintage.engine.discovery.FilterableIgnoringRunnerDecorator,\ org.junit.vintage.engine.discovery.IgnoringRunnerDecorator ``` * fix: include gax testlib in specific poms * chore: run lint job on java 17 This matches the minimum supported java version by the spotify fmt plugin
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the ongoing nightly failures.
gax-java contains native-image configurations that are common to all libraries. In this PR, we add this testlib jar to the libraries that fail during our nightly GraalVM tests.
The affected libraries were inferred from the list of failures in this nightly job. This job uses
--fail-at-end(.kokoro/common.sh), so the list is complete (i.e. the failures don't prevent us from finding other failures).The affected libraries fail with messages that are caught by this gax testlib. For example:
and
The gax testlib includes these classes: