Support setting library header in grpc services #1078
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- add libraryName() and libraryVersion() to ServiceOptions - use setClientLibHeader in DefaultPubSubRpc
Contributor
Author
|
/cc @aozarov |
| } | ||
|
|
||
| /** | ||
| * Returns {@code gcloud-java}, the library's name, as a string. |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
Contributor
|
Looks good. 2 minor comments. |
Contributor
|
Looks good! |
mziccard
added a commit
to mziccard/gcloud-java
that referenced
this pull request
Jun 27, 2016
- add libraryName() and libraryVersion() to ServiceOptions - use setClientLibHeader in DefaultPubSubRpc
github-actions bot
pushed a commit
that referenced
this pull request
Oct 5, 2022
🤖 I have created a release *beep* *boop* --- ## [2.3.5](https://togithub.com/googleapis/java-translate/compare/v2.3.4...v2.3.5) (2022-10-03) ### Dependencies * Update dependency com.google.cloud:google-cloud-core to v2.8.12 ([#1076](https://togithub.com/googleapis/java-translate/issues/1076)) ([d76889c](https://togithub.com/googleapis/java-translate/commit/d76889cc92fb1cad71d4be4552d68c962deddfed)) * Update dependency com.google.cloud:google-cloud-core to v2.8.13 ([#1083](https://togithub.com/googleapis/java-translate/issues/1083)) ([3819209](https://togithub.com/googleapis/java-translate/commit/3819209e110df183aba335e22b404c6bc415772a)) * Update dependency com.google.cloud:google-cloud-core to v2.8.14 ([#1084](https://togithub.com/googleapis/java-translate/issues/1084)) ([c2e0417](https://togithub.com/googleapis/java-translate/commit/c2e04178b37396435f6c24d180fd67cbf9bfba3c)) * Update dependency com.google.cloud:google-cloud-core to v2.8.15 ([#1085](https://togithub.com/googleapis/java-translate/issues/1085)) ([554b02f](https://togithub.com/googleapis/java-translate/commit/554b02fa2b97ff4841ae35e7e43ab6c72335a97e)) * Update dependency com.google.cloud:google-cloud-core to v2.8.18 ([#1087](https://togithub.com/googleapis/java-translate/issues/1087)) ([dc3663e](https://togithub.com/googleapis/java-translate/commit/dc3663e29574467bd25400c7d91bd0c1ca036038)) * Update dependency com.google.cloud:google-cloud-core to v2.8.19 ([#1090](https://togithub.com/googleapis/java-translate/issues/1090)) ([982faf0](https://togithub.com/googleapis/java-translate/commit/982faf0eba19064a3b82ad45c2567e613aa225e9)) * Update dependency com.google.cloud:google-cloud-shared-dependencies to v3.0.4 ([#1092](https://togithub.com/googleapis/java-translate/issues/1092)) ([34fd42e](https://togithub.com/googleapis/java-translate/commit/34fd42e19a494aebfd1f6ab73274ed5b38f175a4)) * Update dependency com.google.cloud:google-cloud-storage to v2.12.0 ([#1078](https://togithub.com/googleapis/java-translate/issues/1078)) ([06861c1](https://togithub.com/googleapis/java-translate/commit/06861c153ec52be12b8d2e891482bdef76f0a850)) --- This PR was generated with [Release Please](https://togithub.com/googleapis/release-please). See [documentation](https://togithub.com/googleapis/release-please#release-please).
suztomo
pushed a commit
that referenced
this pull request
Feb 1, 2023
…1078) * chore: Upgrade to later version of gcp-uploader and protobuf * chore: Add secretstorage version * chore: Use python 3.9.13 * chore: Unpin all python versions * chore: Rerun pipcompile tool * chore: Rerun pipcompile tool with --allow-unsafe * chore: Add --require-hashes * chore: Update requirements file * chore: Remove --require-hashes * chore: Print python version * chore: Add new generated hashes for requirements.txt * chore: Remove python version check in cloud build * chore: Allow synthtool to update python dependencies * chore: Add typing-extensions into requirements * chore: Unpin docker requirements.in file * chore: Add java synthtool validation * chore: Add check to import java synthtool python package Source-Link: googleapis/synthtool@91904bf Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-java:latest@sha256:4566cf7fcd0eece77705330267b2b61a70165711c7829d049b60bc2f1bbcd74e Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
meltsufin
pushed a commit
that referenced
this pull request
Dec 22, 2025
…to v3.11.2 (#1078) * chore(deps): update dependency com.google.cloud:google-cloud-logging to v3.11.2 * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
chingor13
pushed a commit
that referenced
this pull request
Jan 6, 2026
…lugin to v3.4.0 (#1078) [](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [org.codehaus.mojo:build-helper-maven-plugin](https://www.mojohaus.org/build-helper-maven-plugin/) ([source](https://togithub.com/mojohaus/build-helper-maven-plugin)) | `3.3.0` -> `3.4.0` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>mojohaus/build-helper-maven-plugin</summary> ### [`v3.4.0`](https://togithub.com/mojohaus/build-helper-maven-plugin/releases/tag/3.4.0) ##### Changes ##### 🚀 New features and improvements - Get rid of ArtifactRepository - ${localRepository} ([#​179](https://togithub.com/mojohaus/build-helper-maven-plugin/pull/179)) [@​slawekjaranowski](https://togithub.com/slawekjaranowski) - Added a property name to the "sources" parameter for CLI usage ([#​157](https://togithub.com/mojohaus/build-helper-maven-plugin/pull/157)) [@​gjd6640](https://togithub.com/gjd6640) ##### 🐛 Bug Fixes - Use UTF-8 for the pom ([#​173](https://togithub.com/mojohaus/build-helper-maven-plugin/pull/173)) [@​gnodet](https://togithub.com/gnodet) ##### 📦 Dependency updates - Bump maven-plugin-annotations from 3.8.1 to 3.8.2 ([#​177](https://togithub.com/mojohaus/build-helper-maven-plugin/pull/177)) [@​dependabot](https://togithub.com/dependabot) - Bump parent from 72 to 74 ([#​175](https://togithub.com/mojohaus/build-helper-maven-plugin/pull/175)) [@​slawekjaranowski](https://togithub.com/slawekjaranowski) - Bump maven-invoker-plugin to 3.5.1 - add support to run its with Java 20 ([#​172](https://togithub.com/mojohaus/build-helper-maven-plugin/pull/172)) [@​slachiewicz](https://togithub.com/slachiewicz) - Bump actions/stale from 7 to 8 ([#​171](https://togithub.com/mojohaus/build-helper-maven-plugin/pull/171)) [@​dependabot](https://togithub.com/dependabot) - Bump maven-plugin-annotations from 3.7.1 to 3.8.1 ([#​169](https://togithub.com/mojohaus/build-helper-maven-plugin/pull/169)) [@​dependabot](https://togithub.com/dependabot) - Bump plexus-utils from 3.5.0 to 3.5.1 ([#​170](https://togithub.com/mojohaus/build-helper-maven-plugin/pull/170)) [@​dependabot](https://togithub.com/dependabot) - Bump mojo-parent from 70 to 72 ([#​165](https://togithub.com/mojohaus/build-helper-maven-plugin/pull/165)) [@​dependabot](https://togithub.com/dependabot) - Bump assertj-core from 3.24.1 to 3.24.2 ([#​164](https://togithub.com/mojohaus/build-helper-maven-plugin/pull/164)) [@​dependabot](https://togithub.com/dependabot) - Bump maven-plugin-annotations from 3.7.0 to 3.7.1 ([#​163](https://togithub.com/mojohaus/build-helper-maven-plugin/pull/163)) [@​dependabot](https://togithub.com/dependabot) - Bump assertj-core from 3.24.0 to 3.24.1 ([#​162](https://togithub.com/mojohaus/build-helper-maven-plugin/pull/162)) [@​dependabot](https://togithub.com/dependabot) - Bump assertj-core from 3.23.1 to 3.24.0 ([#​161](https://togithub.com/mojohaus/build-helper-maven-plugin/pull/161)) [@​dependabot](https://togithub.com/dependabot) - Bump actions/stale from 6 to 7 ([#​160](https://togithub.com/mojohaus/build-helper-maven-plugin/pull/160)) [@​dependabot](https://togithub.com/dependabot) - Bump maven-plugin-annotations from 3.6.4 to 3.7.0 ([#​158](https://togithub.com/mojohaus/build-helper-maven-plugin/pull/158)) [@​dependabot](https://togithub.com/dependabot) - Bump plexus-utils from 3.4.2 to 3.5.0 ([#​151](https://togithub.com/mojohaus/build-helper-maven-plugin/pull/151)) [@​dependabot](https://togithub.com/dependabot) - Bump mojo-parent from 69 to 70 ([#​141](https://togithub.com/mojohaus/build-helper-maven-plugin/pull/141)) [@​dependabot](https://togithub.com/dependabot) - Bump mojo-parent from 68 to 69 ([#​140](https://togithub.com/mojohaus/build-helper-maven-plugin/pull/140)) [@​dependabot](https://togithub.com/dependabot) - Bump mojo-parent from 67 to 68 ([#​138](https://togithub.com/mojohaus/build-helper-maven-plugin/pull/138)) [@​dependabot](https://togithub.com/dependabot) - Bump assertj-core from 3.22.0 to 3.23.1 ([#​137](https://togithub.com/mojohaus/build-helper-maven-plugin/pull/137)) [@​dependabot](https://togithub.com/dependabot) - Bump plexus-utils from 3.4.1 to 3.4.2 ([#​135](https://togithub.com/mojohaus/build-helper-maven-plugin/pull/135)) [@​dependabot](https://togithub.com/dependabot) - Bump actions/stale from 4 to 5 ([#​132](https://togithub.com/mojohaus/build-helper-maven-plugin/pull/132)) [@​dependabot](https://togithub.com/dependabot) - Bump actions/setup-java from 2 to 3 ([#​133](https://togithub.com/mojohaus/build-helper-maven-plugin/pull/133)) [@​dependabot](https://togithub.com/dependabot) - Bump mojo-parent from 65 to 67 ([#​130](https://togithub.com/mojohaus/build-helper-maven-plugin/pull/130)) [@​dependabot](https://togithub.com/dependabot) - Bump actions/checkout from 2 to 3 ([#​128](https://togithub.com/mojohaus/build-helper-maven-plugin/pull/128)) [@​dependabot](https://togithub.com/dependabot) - Bump maven-plugin-annotations from 3.6.2 to 3.6.4 ([#​126](https://togithub.com/mojohaus/build-helper-maven-plugin/pull/126)) [@​dependabot](https://togithub.com/dependabot) - Bump release-drafter/release-drafter from 5.15.0 to 5.16.1 ([#​123](https://togithub.com/mojohaus/build-helper-maven-plugin/pull/123)) [@​dependabot](https://togithub.com/dependabot) - Bump testng from 7.4.0 to 7.5 ([#​122](https://togithub.com/mojohaus/build-helper-maven-plugin/pull/122)) [@​dependabot](https://togithub.com/dependabot) - Bump plexus-utils from 3.0.24 to 3.4.1 ([#​121](https://togithub.com/mojohaus/build-helper-maven-plugin/pull/121)) [@​dependabot](https://togithub.com/dependabot) ##### 👻 Maintenance - Enable spotless for code formatting ([#​180](https://togithub.com/mojohaus/build-helper-maven-plugin/pull/180)) [@​slawekjaranowski](https://togithub.com/slawekjaranowski) - Move tests to Junit 5 ([#​174](https://togithub.com/mojohaus/build-helper-maven-plugin/pull/174)) [@​slachiewicz](https://togithub.com/slachiewicz) - Declare Maven Core dependencies as provided ([#​125](https://togithub.com/mojohaus/build-helper-maven-plugin/pull/125)) [@​stefanseifert](https://togithub.com/stefanseifert) - Use only major version (v5) of release drafter ([#​124](https://togithub.com/mojohaus/build-helper-maven-plugin/pull/124)) [@​stefanseifert](https://togithub.com/stefanseifert) </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://app.renovatebot.com/dashboard#github/googleapis/java-logging-logback). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNS40OC4yIiwidXBkYXRlZEluVmVyIjoiMzUuNDguMiJ9-->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR does the following:
libraryName()andlibraryVersion()toServiceOptionssetClientLibHeaderinDefaultPubSubRpc