chore: update renovate to only update libraries-bom version in README.md in 4 modules
#10768
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
"generation diff / root-pom" check will pass when we update the library generation image tag. |
blakeli0
reviewed
Apr 30, 2024
| "depNameTemplate": "com.google.cloud:sdk-platform-java-config", | ||
| "datasourceTemplate": "maven" | ||
| }, | ||
| { |
Contributor
There was a problem hiding this comment.
I don't think we want to remove this section all together, we still need it for vertex-ai, dns, notification and grafeas.
Contributor
Author
There was a problem hiding this comment.
I changed the config to only update libraries bom version in these 4 modules.
PR title and description are also modified.
…DME.md" This reverts commit eb72ebd.
README.mdREADME.md in 4 modules
blakeli0
approved these changes
May 1, 2024
burkedavison
added a commit
that referenced
this pull request
Dec 26, 2024
Original PR to limit renovate-bot's libraries-bom updates due to conflict with hermetic build: #10768 However, we want the native-image-sample to be included in these updates. It is not updated by hermetic build.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR:
README.mdin 4 modules (java-dns, java-grafeas, java-notification and java-vertexai) since this value in other modules is updated by hermetic build scripts.To verify the change: