fix(logging): Use instance/attributes/cluster-location for location on GKE#9094
Merged
gkevinzheng merged 6 commits intogoogleapis:mainfrom Dec 11, 2023
Merged
fix(logging): Use instance/attributes/cluster-location for location on GKE#9094gkevinzheng merged 6 commits intogoogleapis:mainfrom
gkevinzheng merged 6 commits intogoogleapis:mainfrom
Conversation
|
Thanks. Once this is merged, I imagine it will be mentioned in the next release change log. For users writing |
cindy-peng
approved these changes
Dec 11, 2023
bhshkh
approved these changes
Dec 11, 2023
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use
instance/attributes/cluster-locationfor location on GKE to set the value of location to the cluster location as opposed to just the zone, to bring it in line with what other logging libraries do: see https://github.com/googleapis/google-cloud-cpp/blob/4ba2cc4d1d0cfdd70dec6d1affb26423d0e9dac1/google/cloud/opentelemetry/internal/resource_detector_impl.cc#L103C51-L103C67 and https://github.com/googleapis/google-cloud-cpp/blob/850564f330ac6e918d6d40ac1ab17a200282a196/google/cloud/opentelemetry/internal/monitored_resource.cc#L88 for C++, and for what is tagged under location in other GKE logging statements.See also https://cloud.google.com/kubernetes-engine/docs/concepts/workload-identity#instance_metadata
Fixes #9083 #9070