-
Notifications
You must be signed in to change notification settings - Fork 1.5k
logging: detectKubernetesResource() should set region not zone for location #9070
Copy link
Copy link
Closed
Closed
Copy link
Labels
api: loggingIssues related to the Cloud Logging API.Issues related to the Cloud Logging API.priority: p3Desirable enhancement or fix. May not be included in next release.Desirable enhancement or fix. May not be included in next release.triage meI really want to be triaged.I really want to be triaged.type: bugError or flaw in code with unintended results or allowing sub-optimal usage patterns.Error or flaw in code with unintended results or allowing sub-optimal usage patterns.
Description
Client
Logging
Environment
on GKE
Go Environment
N/A
Code
N/A
Expected behavior
detectKubernetesResource() set region for location
Actual behavior
detectKubernetesResource() set zone for location
Screenshots
N/A
Additional context
detectKubernetesResource() currenly set zone(like "us-central1-b") for location.
But default stackdriver exporter in GKE uses region(like "us-central1") for location and GCP UI generates Cloud Logging URL which uses region for location at Pod logs page.
So, when developers want to switch from stackdriver exporter to direct exporter by this library, location value is not compatible between changes and default detection is not useful.
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
api: loggingIssues related to the Cloud Logging API.Issues related to the Cloud Logging API.priority: p3Desirable enhancement or fix. May not be included in next release.Desirable enhancement or fix. May not be included in next release.triage meI really want to be triaged.I really want to be triaged.type: bugError or flaw in code with unintended results or allowing sub-optimal usage patterns.Error or flaw in code with unintended results or allowing sub-optimal usage patterns.