feat(spanner): add support for handling null values in array of proto columns#7042
Merged
harshachinta merged 3 commits intogoogleapis:proto-column-enhancement-alphafrom Nov 17, 2022
Conversation
rahul2393
approved these changes
Nov 15, 2022
Shua1
approved these changes
Nov 16, 2022
| // As the ENUM elements in the array are value type and not pointer type, | ||
| // we cannot support NULL values in the array | ||
| if isNull { | ||
| return errNilNotAllowed(ptr, "*[]*protoreflect.Enum") |
There was a problem hiding this comment.
The error msg is:
... Use *[]*protoreflect.Enum, an array with pointer type elements to read Null values.
Is this expected?
olavloite
approved these changes
Nov 16, 2022
Contributor
olavloite
left a comment
There was a problem hiding this comment.
LGTM, with a small nit on the error message.
83e345a to
d797b45
Compare
harshachinta
added a commit
that referenced
this pull request
May 7, 2024
* feat(spanner): add support for Proto Columns (#6886) * feat(spanner): Adding support for Proto Message and Proto Enum * feat(spanner): Add license header to new files * code refactoring and additional checks * nit: code changes * go.mod update to prevent failing builds * go.mod update to prevent failing builds * go.mod and build_samples.sh update to prevent failing builds * revert back grpc version * revert back changes * Using standard Singers example, refactoring redundant code * code and proto refactoring * Add proto_type_fqn for Proto Message and Proto Enum * code refactoring * go mod tidy: go.mod and go.sum version updates * add changes to support compatibility between Int64 and Enum & compatibility between Bytes and Proto * Revert "go mod tidy: go.mod and go.sum version updates" This reverts commit 484b00c. * add Integration Tests for Proto Message, Proto Enum, compatibility tests * code refactoring * code refactoring * add unit tests for nil proto types * Add error when nil proto message or nil enum is passed * feat(spanner): add support for handling null value in Proto columns (#6954) * feat(spanner): add support for handling null value in Proto columns * code refactor: get protoTypeFqn from user defined nil types * code refactoring * code refactoring * code refactoring * code refactoring * Add tests for MarshalJSON and UnmarshalJSON methods * refactoring test file * code refactoring * feat(spanner): add support for Array of Proto columns (#7014) * feat(spanner): add support for array of proto columns * refactoring comments and added negative test cases while reading array of protos * change decoding logic of handling array of proto columns * feat(spanner): add support for handling null values in array of proto columns (#7042) * feat(spanner): add support for handling null values in Array of Proto Columns * add comments for code readability * nit: change in error message * feat(spanner): Modify configuration for integration test and add license header (#7059) * feat(spanner): update go-genproto dependency (#7066) * feat(spanner): support for enum columns as keys, index and integration tests (#7091) * feat(spanner): support for proto columns as primary key and tests for parameterized queries, primary key and indexes * feat(spanner): close read-only transaction to prevent session leak * feat(spanner): update table schema to have GPK on proto field * feat(spanner): add proto changes to support proto columns feature * feat(spanner): remove gen-proto dep overwrite for proto column support * feat(spanner): remove gen-proto dep overwrite from kokoro build * feat(spanner): reset array of proto, enum when null from database (#7176) * feat(spanner): reset array of proto, enum when null from database * feat(spanner): fix license header to fix vet.sh build * feat(spanner): fix proto generated file to fix vet.sh build * feat(spanner): organize imports to fix vet.sh build * feat(spanner): golint changes to fix vet.sh build * feat(spanner): add support for Proto column DDL (#7292) * feat(spanner): add proto changes for Proto Columns DDL support * feat(spanner): add Proto descriptor file and integration tests for Proto DDL feature * feat(spanner): skip pg tests and code refactoring for proto ddl * feat(spanner): rename NewDatabaseAdminRESTClient to NewDatabaseAdminClient due to visibility label issue fix * feat(spanner): remove hardcoded cloud-devel host * feat(spanner): remove hardcoded project id * feat(spanner): revert autogenerated code * feat(spanner): just to validate integration tests running * feat(spanner): change copyright year * feat(spanner): set project id for integration tests * feat(spanner): use jsoniter instead of json for marshal and unmarshal * feat(spanner): revert presubmit.sh changes * chore(spanner): run integration tests in presubmit * chore(spanner): revert presubmit.sh changes * feat(spanner): fix json --------- Co-authored-by: rahul2393 <irahul@google.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds support for handling null values in array of proto columns.