chore(storage): retry configs for gRPC media ops#6754
Merged
gcf-merge-on-green[bot] merged 3 commits intoSep 28, 2022
Conversation
Adds retry config to grpcReader and grpcWriter types so that they can be propagated to operations as needed. Ensure that the configured values are used for all retry calls, and that UserProject is consistently passed through as well.
noahdietz
approved these changes
Sep 27, 2022
noahdietz
left a comment
Contributor
There was a problem hiding this comment.
Well done, makes perfect sense.
tritone
added a commit
to tritone/google-cloud-go
that referenced
this pull request
Sep 28, 2022
I missed a case where the shouldRetry function could be nil in googleapis#6754, which causes a panic in integration tests. Fixes googleapis#6760 (this is the actual failure) Fixes googleapis#6757 Fixes googleapis#6758 Fixes googleapis#6759
BrennaEpp
pushed a commit
that referenced
this pull request
Sep 28, 2022
kimihrr
pushed a commit
to kimihrr/google-cloud-go-kimia
that referenced
this pull request
Sep 28, 2022
Adds retry config to grpcReader and grpcWriter types so that they can be propagated to operations as needed. Ensure that the configured values are used for all retry calls, and that UserProject is consistently passed through as well.
kimihrr
pushed a commit
to kimihrr/google-cloud-go-kimia
that referenced
this pull request
Sep 28, 2022
I missed a case where the shouldRetry function could be nil in googleapis#6754, which causes a panic in integration tests. Fixes googleapis#6760 (this is the actual failure) Fixes googleapis#6757 Fixes googleapis#6758 Fixes googleapis#6759
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds retry config to grpcReader and grpcWriter types so that they can be propagated to operations as needed. Ensure that the configured values are used for all retry calls, and that UserProject is consistently passed through as well.