refactor(storage): replace manual retries in tests#6510
Conversation
tritone
left a comment
There was a problem hiding this comment.
Generally looks good, a few minor comments
| t.Errorf("ACL.List: object ACL list failed: %v", err) | ||
| } | ||
|
|
||
| if !containsACL(acls, aclEntity, RoleReader) { |
There was a problem hiding this comment.
Unfortunately this check needs to be retried as well, since it's possible/likely that the call will succeed but the check will fail.
It might be better to leave the original code for stuff with this pattern.
There was a problem hiding this comment.
Oh interesting... so it's possible for a situation where the metadata is updated for bucket level access policy but the acls are not yet populated?
There was a problem hiding this comment.
Actually I looked at this again and I think I was wrong, I believe that as long as ACL.List() succeeds then it should contain the correct items in this instance. Feel free to revert to what you had originally!
tritone
left a comment
There was a problem hiding this comment.
LGTM, you can revert the changes you made for the UBLA/BPO tests based on my last review
Fixes #5032
Also adds a retry to the HMAC key test that fixes #6544