Skip to content

feat(bigquery): add reservation usage stats to query statistics#3403

Merged
shollyman merged 6 commits intogoogleapis:masterfrom
shollyman:fr-querystats
Dec 8, 2020
Merged

feat(bigquery): add reservation usage stats to query statistics#3403
shollyman merged 6 commits intogoogleapis:masterfrom
shollyman:fr-querystats

Conversation

@shollyman
Copy link
Copy Markdown
Contributor

This PR plumbs through reservation usage stats reported per-job.

Also added a small integration test for testing query statistics,
as we didn't have one previously.

This PR plumbs through reservation usage stats reported per-job.

Also added a small integration test for testing query statistics,
as we didn't have one previously.
@shollyman shollyman requested a review from a team December 7, 2020 19:22
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Dec 7, 2020
@shollyman shollyman changed the title feat: add reservation usage stats to query statistics feat(bigquery): add reservation usage stats to query statistics Dec 7, 2020
@shollyman shollyman requested a review from hongalex December 7, 2020 19:22
Copy link
Copy Markdown
Member

@codyoss codyoss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just a few nits

@shollyman
Copy link
Copy Markdown
Contributor Author

Just did a secondary review. This is a mirrored stat, hoisting this up outside of query stats.

@shollyman shollyman added the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Dec 7, 2020
This is reported at the top-level, to support other slot-consuming
job types like load jobs.  We'll ignore the query-specific copy.
@shollyman shollyman removed the request for review from hongalex December 8, 2020 00:32
@shollyman shollyman removed cla: yes This human has signed the Contributor License Agreement. do not merge Indicates a pull request not ready for merge, due to either quality or timing. labels Dec 8, 2020
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Dec 8, 2020
@shollyman shollyman merged commit 112bcde into googleapis:master Dec 8, 2020
@shollyman shollyman deleted the fr-querystats branch December 8, 2020 20:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants