feat(storage): add StartOffset and EndOffset to Query#2563
feat(storage): add StartOffset and EndOffset to Query#2563AlisskaPie merged 13 commits intogoogleapis:masterfrom
Conversation
|
@tritone Do we need to add a test here? If so, where it will be better to add this test? |
tritone
left a comment
There was a problem hiding this comment.
I think we'd definitely want a test for this; I need to look at existing tests for ObjectIterator to see what makes sense.
@frankyn can you confirm that we'd want to expose this feature through the client library? Looks like it was a request from an external user.
|
Hi @tritone, yes these fields are okay to surface as they're published in public documentation: https://cloud.google.com/storage/docs/json_api/v1/objects/list |
tritone
left a comment
There was a problem hiding this comment.
I think an integration test might make sense for this feature-- something like
google-cloud-go/storage/integration_test.go
Line 1055 in 2a870c2
Yes, I'll do this. |
tritone
left a comment
There was a problem hiding this comment.
Looks good-- a couple comments re: testing but should be ready to go once these are fixed.
- new function testObjectIteratorWithOffset - leave it in the AllSelectedAttrs - remove it in the SelectedAttrs
…nto add_offsets_to_query
…gle-cloud-go into add_offsets_to_query
* add StartOffset and EndOffset to Query * fix comments * add testObjectIteratorOffset, test for StartOffset * cosmetic * move to testObjectIterator * test for EndOffset * small fixes * added offsets to testObjectsIterateSelectedAttrs * added offset to testObjectsIterateAllSelectedAttrs * review changes - new function testObjectIteratorWithOffset - leave it in the AllSelectedAttrs - remove it in the SelectedAttrs Co-authored-by: Chris Cotter <cjcotter@google.com>
Closes #2556