feat(storage): read checksums in gRPC partial reads#14586
Merged
Conversation
Contributor
There was a problem hiding this comment.
Code Review
This pull request implements chunk-level CRC32C checksum validation for gRPC read operations in both storage/grpc_client.go and storage/grpc_reader.go. It introduces new fields to track chunk-specific checksums and adds logic to validate these checksums at message boundaries during Read and WriteTo operations. Feedback was provided to improve code consistency by utilizing the checkAndResetChunkCRC helper method within the runCRCCheck function for gRPCReader, matching the pattern used in gRPCReadObjectReader.
02cc0cb to
c8949bc
Compare
c8949bc to
cb88d69
Compare
cpriti-os
reviewed
May 14, 2026
cpriti-os
reviewed
May 14, 2026
cpriti-os
reviewed
May 14, 2026
cpriti-os
reviewed
May 14, 2026
cpriti-os
reviewed
May 14, 2026
c9643fc to
22c46e5
Compare
cpriti-os
reviewed
May 15, 2026
cpriti-os
reviewed
May 15, 2026
cpriti-os
approved these changes
May 15, 2026
This was referenced Jun 16, 2026
Closed
krishnamd-jkp
added a commit
that referenced
this pull request
Jun 26, 2026
🤖 I have created a release *beep* *boop* --- ## [1.63.0](storage/v1.62.2...storage/v1.63.0) (2026-06-25) ### Features * **go:** Add full object checksum for negative offsets > size ([#20026](#20026)) ([a04d980](a04d980)) * **storage:** Add client feature tracking in HTTP client ([#14691](#14691)) ([319cc4c](319cc4c)) * **storage:** App Centric Observability ([#14685](#14685)) ([c3273bb](c3273bb)) * **storage:** Read checksums in gRPC partial reads ([#14586](#14586)) ([d29f68a](d29f68a)) * **storage:** Support deleteSourceObjects option in object compose ([#14704](#14704)) ([0d2d680](0d2d680)) * Update API sources and regenerate ([#14701](#14701)) ([a9b7921](a9b7921)) ### Bug Fixes * **storage:** Add server closed idle connection to retriable errors ([#14594](#14594)) ([a6bd392](a6bd392)) * **storage:** Fix race condition during retries in gRPC writer ([#14649](#14649)) ([c781a75](c781a75)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). --------- Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com> Co-authored-by: Krishnam Dhanush <krishnamd@google.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.