chore: librarian generate pull request: 20260114T080435Z#13598
chore: librarian generate pull request: 20260114T080435Z#13598JoeWang1127 merged 1 commit intomainfrom
Conversation
Summary of ChangesHello @cloud-sdk-librarian-robot, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request integrates a series of generated client library updates across multiple Google Cloud services. The changes introduce new functionalities, resources, and API methods, particularly enhancing NetApp's storage management, adding synchronous operations for Gemini Data Analytics, improving Config API's migration and error reporting, and expanding BackupDR's protection summary capabilities. It also refines Spanner's client context and updates Pub/Sub's message transformation options, alongside general maintenance like copyright year updates. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request contains auto-generated updates for several Google Cloud client libraries, including backupdr, config, geminidataanalytics, and others. The changes primarily consist of new API methods, updated dependencies, and copyright year bumps. The generated code appears to be correct and follows standard patterns. I've found one minor style issue in a documentation comment, which I've pointed out for consistency.
| return c.internalClient.GetResourceDrift(ctx, req, opts...) | ||
| } | ||
|
|
||
| // GetAutoMigrationConfig get the AutoMigrationConfig for a given project and location. |
There was a problem hiding this comment.
According to the Go style guide (Effective Go), comments for exported functions should start with the function's name. This comment starts with a lowercase 'g'.
| // GetAutoMigrationConfig get the AutoMigrationConfig for a given project and location. | |
| // GetAutoMigrationConfig gets the AutoMigrationConfig for a given project and location. |
References
- Doc comments for public-facing components should begin with the name of the documented entity. The first sentence should be a summary of the entity. (link)
PR created by the Librarian CLI to generate Cloud Client Libraries code from protos. BEGIN_COMMIT BEGIN_NESTED_COMMIT feat: Update NetApp v1 API with Host Groups, Block Volumes, Cache Volumes, and Backup Restore This CL introduces several new features and enhancements to the NetApp API: - **Host Groups:** Added a new `HostGroup` resource to manage collections of hosts for Block Volume access. Includes full CRUD operations. - **Block Volumes:** Enhanced the `Volume` resource to support `ISCSI` protocol and `BlockDevice` configurations. - **Cache Volumes:** Added `CacheParameters` to the `Volume` resource to support FlexCache volumes. - **Backup Restore:** Introduced a new `RestoreBackupFiles` RPC to restore individual files from a backup. - **CMEK for Backup Vaults:** Added fields to `BackupVault` to support Customer Managed Encryption Keys (CMEK). - **Storage Pool Type:** Added a `type` field to `StoragePool` to specify support for FILE, UNIFIED, or UNIFIED_LARGE_CAPACITY volumes. - **Location Metadata:** Added `has_ontap_proxy` flag. - Updated copyright year to 2026. PiperOrigin-RevId: 856056649 Library-IDs: netapp Source-link: [googleapis/googleapis@94aa4f5a](googleapis/googleapis@94aa4f5a) END_NESTED_COMMIT BEGIN_NESTED_COMMIT feat: added sync APIs for the CRUD operations of Data Agent PiperOrigin-RevId: 855534426 Library-IDs: geminidataanalytics Source-link: [googleapis/googleapis@fbda01ec](googleapis/googleapis@fbda01ec) END_NESTED_COMMIT BEGIN_NESTED_COMMIT chore: update copyright year for auto-generated protos PiperOrigin-RevId: 855295338 Library-IDs: run Source-link: [googleapis/googleapis@1e3baa91](googleapis/googleapis@1e3baa91) END_NESTED_COMMIT BEGIN_NESTED_COMMIT feat: added error code when failing import values from an external source PiperOrigin-RevId: 854277617 Library-IDs: config Source-link: [googleapis/googleapis@6145b5ff](googleapis/googleapis@6145b5ff) END_NESTED_COMMIT BEGIN_NESTED_COMMIT feat: add support for enabling automigration from deprecated Terraform versions PiperOrigin-RevId: 854277617 Library-IDs: config Source-link: [googleapis/googleapis@6145b5ff](googleapis/googleapis@6145b5ff) END_NESTED_COMMIT BEGIN_NESTED_COMMIT feat: A new message `ListResourceBackupConfigsRequest` is added PiperOrigin-RevId: 854009996 Library-IDs: backupdr Source-link: [googleapis/googleapis@524b2de6](googleapis/googleapis@524b2de6) END_NESTED_COMMIT BEGIN_NESTED_COMMIT feat: A new service `BackupDrProtectionSummary` is added PiperOrigin-RevId: 854009996 Library-IDs: backupdr Source-link: [googleapis/googleapis@524b2de6](googleapis/googleapis@524b2de6) END_NESTED_COMMIT BEGIN_NESTED_COMMIT feat: A new message `BackupDrPlanRule` is added PiperOrigin-RevId: 854009996 Library-IDs: backupdr Source-link: [googleapis/googleapis@524b2de6](googleapis/googleapis@524b2de6) END_NESTED_COMMIT BEGIN_NESTED_COMMIT feat: A new message `PitrSettings` is added PiperOrigin-RevId: 854009996 Library-IDs: backupdr Source-link: [googleapis/googleapis@524b2de6](googleapis/googleapis@524b2de6) END_NESTED_COMMIT BEGIN_NESTED_COMMIT feat: A new message `BackupDrPlanConfig` is added PiperOrigin-RevId: 854009996 Library-IDs: backupdr Source-link: [googleapis/googleapis@524b2de6](googleapis/googleapis@524b2de6) END_NESTED_COMMIT BEGIN_NESTED_COMMIT feat: A new message `BackupDrTemplateConfig` is added PiperOrigin-RevId: 854009996 Library-IDs: backupdr Source-link: [googleapis/googleapis@524b2de6](googleapis/googleapis@524b2de6) END_NESTED_COMMIT BEGIN_NESTED_COMMIT feat: A new message `ResourceBackupConfig` is added PiperOrigin-RevId: 854009996 Library-IDs: backupdr Source-link: [googleapis/googleapis@524b2de6](googleapis/googleapis@524b2de6) END_NESTED_COMMIT BEGIN_NESTED_COMMIT feat: A new message `ListResourceBackupConfigsResponse` is added PiperOrigin-RevId: 854009996 Library-IDs: backupdr Source-link: [googleapis/googleapis@524b2de6](googleapis/googleapis@524b2de6) END_NESTED_COMMIT BEGIN_NESTED_COMMIT feat: A new resource_definition `backupdr.googleapis.com/ResourceBackupConfig` is added PiperOrigin-RevId: 854009996 Library-IDs: backupdr Source-link: [googleapis/googleapis@524b2de6](googleapis/googleapis@524b2de6) END_NESTED_COMMIT BEGIN_NESTED_COMMIT feat: A new message `BackupLocation` is added PiperOrigin-RevId: 854009996 Library-IDs: backupdr Source-link: [googleapis/googleapis@524b2de6](googleapis/googleapis@524b2de6) END_NESTED_COMMIT BEGIN_NESTED_COMMIT feat: A new message `BackupConfigDetails` is added PiperOrigin-RevId: 854009996 Library-IDs: backupdr Source-link: [googleapis/googleapis@524b2de6](googleapis/googleapis@524b2de6) END_NESTED_COMMIT BEGIN_NESTED_COMMIT chore: adjust initial_poll_delay for CreateDatabase and UpdateDatabaseDdl LRO operations PiperOrigin-RevId: 853884590 Library-IDs: spanner Source-link: [googleapis/googleapis@136a2c43](googleapis/googleapis@136a2c43) END_NESTED_COMMIT BEGIN_NESTED_COMMIT docs: A comment for field `analytics_hub_subscription_info` in message `.google.pubsub.v1.Subscription` is updated PiperOrigin-RevId: 853856321 Library-IDs: pubsub/v2 Source-link: [googleapis/googleapis@9fb55c41](googleapis/googleapis@9fb55c41) END_NESTED_COMMIT BEGIN_NESTED_COMMIT docs: A comment for field `subscription` in message `.google.pubsub.v1.CreateSnapshotRequest` is updated PiperOrigin-RevId: 853856321 Library-IDs: pubsub/v2 Source-link: [googleapis/googleapis@9fb55c41](googleapis/googleapis@9fb55c41) END_NESTED_COMMIT BEGIN_NESTED_COMMIT feat: Add AIInference MessageTransform type PiperOrigin-RevId: 853856321 Library-IDs: pubsub/v2 Source-link: [googleapis/googleapis@9fb55c41](googleapis/googleapis@9fb55c41) END_NESTED_COMMIT BEGIN_NESTED_COMMIT docs: A comment for field `topic` in message `.google.pubsub.v1.Subscription` is updated PiperOrigin-RevId: 853856321 Library-IDs: pubsub/v2 Source-link: [googleapis/googleapis@9fb55c41](googleapis/googleapis@9fb55c41) END_NESTED_COMMIT BEGIN_NESTED_COMMIT docs: Marking MODIFIED_CUSTOMER_INITIATED_ACCESS and MODIFIED_GOOGLE_INITIATED_SYSTEM_OPERATION Key Access Justification codes as deprecated in favor of GOOGLE_RESPONSE_TO_PRODUCTION_ALERT PiperOrigin-RevId: 853754070 Library-IDs: kms Source-link: [googleapis/googleapis@f8142673](googleapis/googleapis@f8142673) END_NESTED_COMMIT BEGIN_NESTED_COMMIT feat: add a ClientContext field to Spanner requests PiperOrigin-RevId: 853323071 Library-IDs: spanner Source-link: [googleapis/googleapis@211d22fa](googleapis/googleapis@211d22fa) END_NESTED_COMMIT BEGIN_NESTED_COMMIT feat: add Secure Parameters to the ClientContext PiperOrigin-RevId: 853323071 Library-IDs: spanner Source-link: [googleapis/googleapis@211d22fa](googleapis/googleapis@211d22fa) END_NESTED_COMMIT END_COMMIT This pull request is generated with proto changes between [googleapis/googleapis@ef6a532b](googleapis/googleapis@ef6a532) (exclusive) and [googleapis/googleapis@94aa4f5a](googleapis/googleapis@94aa4f5) (inclusive). Librarian Version: v0.0.0-20251218164811-cd2252e38d0a Language Image: us-central1-docker.pkg.dev/cloud-sdk-librarian-prod/images-prod/librarian-go@sha256:718167d5c23ed389b41f617b3a00ac839bdd938a6bd2d48ae0c2f1fa51ab1c3d
PR created by the Librarian CLI to generate Cloud Client Libraries code from protos.
BEGIN_COMMIT
BEGIN_NESTED_COMMIT
feat: Update NetApp v1 API with Host Groups, Block Volumes, Cache Volumes, and Backup Restore
This CL introduces several new features and enhancements to the NetApp API:
HostGroupresource to manage collections of hosts for Block Volume access. Includes full CRUD operations.Volumeresource to supportISCSIprotocol andBlockDeviceconfigurations.CacheParametersto theVolumeresource to support FlexCache volumes.RestoreBackupFilesRPC to restore individual files from a backup.BackupVaultto support Customer Managed Encryption Keys (CMEK).typefield toStoragePoolto specify support for FILE, UNIFIED, or UNIFIED_LARGE_CAPACITY volumes.has_ontap_proxyflag.PiperOrigin-RevId: 856056649
Library-IDs: netapp
Source-link: googleapis/googleapis@94aa4f5a
END_NESTED_COMMIT
BEGIN_NESTED_COMMIT
feat: added sync APIs for the CRUD operations of Data Agent
PiperOrigin-RevId: 855534426
Library-IDs: geminidataanalytics
Source-link: googleapis/googleapis@fbda01ec
END_NESTED_COMMIT
BEGIN_NESTED_COMMIT
chore: update copyright year for auto-generated protos
PiperOrigin-RevId: 855295338
Library-IDs: run
Source-link: googleapis/googleapis@1e3baa91
END_NESTED_COMMIT
BEGIN_NESTED_COMMIT
feat: added error code when failing import values from an external source
PiperOrigin-RevId: 854277617
Library-IDs: config
Source-link: googleapis/googleapis@6145b5ff
END_NESTED_COMMIT
BEGIN_NESTED_COMMIT
feat: add support for enabling automigration from deprecated Terraform versions
PiperOrigin-RevId: 854277617
Library-IDs: config
Source-link: googleapis/googleapis@6145b5ff
END_NESTED_COMMIT
BEGIN_NESTED_COMMIT
feat: A new message
ListResourceBackupConfigsRequestis addedPiperOrigin-RevId: 854009996
Library-IDs: backupdr
Source-link: googleapis/googleapis@524b2de6
END_NESTED_COMMIT
BEGIN_NESTED_COMMIT
feat: A new service
BackupDrProtectionSummaryis addedPiperOrigin-RevId: 854009996
Library-IDs: backupdr
Source-link: googleapis/googleapis@524b2de6
END_NESTED_COMMIT
BEGIN_NESTED_COMMIT
feat: A new message
BackupDrPlanRuleis addedPiperOrigin-RevId: 854009996
Library-IDs: backupdr
Source-link: googleapis/googleapis@524b2de6
END_NESTED_COMMIT
BEGIN_NESTED_COMMIT
feat: A new message
PitrSettingsis addedPiperOrigin-RevId: 854009996
Library-IDs: backupdr
Source-link: googleapis/googleapis@524b2de6
END_NESTED_COMMIT
BEGIN_NESTED_COMMIT
feat: A new message
BackupDrPlanConfigis addedPiperOrigin-RevId: 854009996
Library-IDs: backupdr
Source-link: googleapis/googleapis@524b2de6
END_NESTED_COMMIT
BEGIN_NESTED_COMMIT
feat: A new message
BackupDrTemplateConfigis addedPiperOrigin-RevId: 854009996
Library-IDs: backupdr
Source-link: googleapis/googleapis@524b2de6
END_NESTED_COMMIT
BEGIN_NESTED_COMMIT
feat: A new message
ResourceBackupConfigis addedPiperOrigin-RevId: 854009996
Library-IDs: backupdr
Source-link: googleapis/googleapis@524b2de6
END_NESTED_COMMIT
BEGIN_NESTED_COMMIT
feat: A new message
ListResourceBackupConfigsResponseis addedPiperOrigin-RevId: 854009996
Library-IDs: backupdr
Source-link: googleapis/googleapis@524b2de6
END_NESTED_COMMIT
BEGIN_NESTED_COMMIT
feat: A new resource_definition
backupdr.googleapis.com/ResourceBackupConfigis addedPiperOrigin-RevId: 854009996
Library-IDs: backupdr
Source-link: googleapis/googleapis@524b2de6
END_NESTED_COMMIT
BEGIN_NESTED_COMMIT
feat: A new message
BackupLocationis addedPiperOrigin-RevId: 854009996
Library-IDs: backupdr
Source-link: googleapis/googleapis@524b2de6
END_NESTED_COMMIT
BEGIN_NESTED_COMMIT
feat: A new message
BackupConfigDetailsis addedPiperOrigin-RevId: 854009996
Library-IDs: backupdr
Source-link: googleapis/googleapis@524b2de6
END_NESTED_COMMIT
BEGIN_NESTED_COMMIT
chore: adjust initial_poll_delay for CreateDatabase and UpdateDatabaseDdl LRO operations
PiperOrigin-RevId: 853884590
Library-IDs: spanner
Source-link: googleapis/googleapis@136a2c43
END_NESTED_COMMIT
BEGIN_NESTED_COMMIT
docs: A comment for field
analytics_hub_subscription_infoin message.google.pubsub.v1.Subscriptionis updatedPiperOrigin-RevId: 853856321
Library-IDs: pubsub/v2
Source-link: googleapis/googleapis@9fb55c41
END_NESTED_COMMIT
BEGIN_NESTED_COMMIT
docs: A comment for field
subscriptionin message.google.pubsub.v1.CreateSnapshotRequestis updatedPiperOrigin-RevId: 853856321
Library-IDs: pubsub/v2
Source-link: googleapis/googleapis@9fb55c41
END_NESTED_COMMIT
BEGIN_NESTED_COMMIT
feat: Add AIInference MessageTransform type
PiperOrigin-RevId: 853856321
Library-IDs: pubsub/v2
Source-link: googleapis/googleapis@9fb55c41
END_NESTED_COMMIT
BEGIN_NESTED_COMMIT
docs: A comment for field
topicin message.google.pubsub.v1.Subscriptionis updatedPiperOrigin-RevId: 853856321
Library-IDs: pubsub/v2
Source-link: googleapis/googleapis@9fb55c41
END_NESTED_COMMIT
BEGIN_NESTED_COMMIT
docs: Marking MODIFIED_CUSTOMER_INITIATED_ACCESS and MODIFIED_GOOGLE_INITIATED_SYSTEM_OPERATION Key Access Justification codes as deprecated in favor of GOOGLE_RESPONSE_TO_PRODUCTION_ALERT
PiperOrigin-RevId: 853754070
Library-IDs: kms
Source-link: googleapis/googleapis@f8142673
END_NESTED_COMMIT
BEGIN_NESTED_COMMIT
feat: add a ClientContext field to Spanner requests
PiperOrigin-RevId: 853323071
Library-IDs: spanner
Source-link: googleapis/googleapis@211d22fa
END_NESTED_COMMIT
BEGIN_NESTED_COMMIT
feat: add Secure Parameters to the ClientContext
PiperOrigin-RevId: 853323071
Library-IDs: spanner
Source-link: googleapis/googleapis@211d22fa
END_NESTED_COMMIT
END_COMMIT
This pull request is generated with proto changes between
googleapis/googleapis@ef6a532b
(exclusive) and
googleapis/googleapis@94aa4f5a
(inclusive).
Librarian Version: v0.0.0-20251218164811-cd2252e38d0a
Language Image: us-central1-docker.pkg.dev/cloud-sdk-librarian-prod/images-prod/librarian-go@sha256:718167d5c23ed389b41f617b3a00ac839bdd938a6bd2d48ae0c2f1fa51ab1c3d