feat(civil): implement database/sql.Scanner|Valuer (#1145)#11808
Merged
gcf-merge-on-green[bot] merged 5 commits intogoogleapis:mainfrom Mar 19, 2025
Merged
feat(civil): implement database/sql.Scanner|Valuer (#1145)#11808gcf-merge-on-green[bot] merged 5 commits intogoogleapis:mainfrom
gcf-merge-on-green[bot] merged 5 commits intogoogleapis:mainfrom
Conversation
c4f8372 to
238e974
Compare
Member
|
@derekperkins Thanks for opening this PR. I'm trying to direct it to engineers directly involved with database products. Greetings from SLC, UT btw. |
Member
|
cc @rahul2393 |
Contributor
Author
Thanks, you too! You should come to the monthly meetup some time, we usually have ~20-30 people https://www.meetup.com/utahgophers/ |
Member
|
Thanks for the link! Just joined utahgophers/ using my personal acct. |
rahul2393
approved these changes
Mar 12, 2025
Member
|
@derekperkins Looks like your PR got approval! 🎉 Please click "Update branch" and I'll restart the CI, then merge when green. |
Member
|
@derekperkins Oops, sorry but it looks like I need to approve this too. So, that means a harder look and I saw your question about testing. Are you able to run |
Member
|
@shollyman PTAL:
|
674b912 to
0219daf
Compare
Contributor
Author
|
@quartzmo I went ahead and added some tests. They call the functions directly, vs routing through database/sql, but that seems sufficient for here. |
quartzmo
reviewed
Mar 17, 2025
0219daf to
b4b1493
Compare
quartzmo
approved these changes
Mar 17, 2025
b4b1493 to
74ade3c
Compare
shollyman
approved these changes
Mar 19, 2025
Contributor
shollyman
left a comment
There was a problem hiding this comment.
Sorry for the delay getting to this, LGTM.
gcf-merge-on-green bot
pushed a commit
that referenced
this pull request
Mar 20, 2025
🤖 I have created a release *beep* *boop* --- ## [0.120.0](https://togithub.com/googleapis/google-cloud-go/compare/v0.119.0...v0.120.0) (2025-03-20) ### Features * **civil:** Implement database/sql.Scanner|Valuer ([#1145](https://togithub.com/googleapis/google-cloud-go/issues/1145)) ([#11808](https://togithub.com/googleapis/google-cloud-go/issues/11808)) ([cbe4419](https://togithub.com/googleapis/google-cloud-go/commit/cbe4419c17f677c05f3f52c2080861adce705db4)) ### Bug Fixes * **third_party/pkgsite:** Increase comment size limit ([#11877](https://togithub.com/googleapis/google-cloud-go/issues/11877)) ([587b5cc](https://togithub.com/googleapis/google-cloud-go/commit/587b5ccc684ad99cb9eeba897304b7143564d423)) --- This PR was generated with [Release Please](https://togithub.com/googleapis/release-please). See [documentation](https://togithub.com/googleapis/release-please#release-please).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1145. I wasn't sure how to test these in the context of this repo.
Questions: