feat(spanner): add support of multiplexed session support in writeAtleastOnce mutations#10646
Merged
feat(spanner): add support of multiplexed session support in writeAtleastOnce mutations#10646
Conversation
harshachinta
reviewed
Aug 7, 2024
harshachinta
reviewed
Aug 7, 2024
| if sh == nil || sh.getID() == "" || sh.getClient() == nil { | ||
| // No usable session for doing the commit, take one from pool. | ||
| sh, err = t.sp.take(ctx) | ||
| sh, err = t.sp.takeMultiplexed(ctx) |
Contributor
There was a problem hiding this comment.
I assume that it falls back to regular sessions in case there is an issue with multiplexed sessions?
Contributor
Author
There was a problem hiding this comment.
Yes it will fallback to regular session, that logic is handled in takeMultiplexed because that behaviour is common
Contributor
|
LGTM. |
harshachinta
approved these changes
Aug 7, 2024
Contributor
Author
We are not using different env var |
gcf-merge-on-green bot
pushed a commit
that referenced
this pull request
Aug 7, 2024
🤖 I have created a release *beep* *boop* --- ## [1.66.0](https://togithub.com/googleapis/google-cloud-go/compare/spanner/v1.65.0...spanner/v1.66.0) (2024-08-07) ### Features * **spanner/admin/database:** Add support for Cloud Spanner Incremental Backups ([d949cc0](https://togithub.com/googleapis/google-cloud-go/commit/d949cc0e5d44af62154d9d5fd393f25a852f93ed)) * **spanner:** Add support of multiplexed session support in writeAtleastOnce mutations ([#10646](https://togithub.com/googleapis/google-cloud-go/issues/10646)) ([54009ea](https://togithub.com/googleapis/google-cloud-go/commit/54009eab1c3b11a28531ad9e621917d01c9e5339)) * **spanner:** Add support of using multiplexed session with ReadOnlyTransactions ([#10269](https://togithub.com/googleapis/google-cloud-go/issues/10269)) ([7797022](https://togithub.com/googleapis/google-cloud-go/commit/7797022e51d1ac07b8d919c421a8bfdf34a1d53c)) --- This PR was generated with [Release Please](https://togithub.com/googleapis/release-please). See [documentation](https://togithub.com/googleapis/release-please#release-please).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
client.Apply(context.Background(), {mutations}, spanner.ApplyAtLeastOnce())