Skip to content

impl(generator): stop generating internal MakeServiceConnection() helper#9574

Merged
devbww merged 3 commits intogoogleapis:mainfrom
devbww:internal-make-connection
Jul 27, 2022
Merged

impl(generator): stop generating internal MakeServiceConnection() helper#9574
devbww merged 3 commits intogoogleapis:mainfrom
devbww:internal-make-connection

Conversation

@devbww
Copy link
Copy Markdown
Contributor

@devbww devbww commented Jul 27, 2022 •
edited by coryan
Loading

This change is Reviewable

@google-cloud-cpp-bot
Copy link
Copy Markdown
Contributor

google-cloud-cpp-bot commented Jul 27, 2022

Google Cloud Build Logs
For commit: c671b32e94d3f6aeccba2a852263e0b48adff27b

ℹ️ NOTE: Kokoro logs are linked from "Details" below.

@codecov
Copy link
Copy Markdown

codecov Bot commented Jul 27, 2022 •
edited
Loading

Codecov Report

Merging #9574 (c671b32) into main (4b06efd) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #9574      +/-   ##
==========================================
- Coverage   94.37%   94.37%   -0.01%     
==========================================
  Files        1491     1491              
  Lines      137656   137644      -12     
==========================================
- Hits       129916   129902      -14     
- Misses       7740     7742       +2
Impacted Files Coverage Δ
...ion_tests/golden/golden_kitchen_sink_connection.cc 30.30% <ø> (-10.73%) ⬇️
...tion_tests/golden/golden_kitchen_sink_connection.h 100.00% <ø> (ø)
...tion_tests/golden/golden_thing_admin_connection.cc 20.00% <ø> (-8.58%) ⬇️
...ation_tests/golden/golden_thing_admin_connection.h 100.00% <ø> (ø)
generator/internal/connection_generator.cc 58.97% <ø> (-2.94%) ⬇️
...olden/tests/golden_kitchen_sink_connection_test.cc 98.67% <100.00%> (+<0.01%) ⬆️
...golden/tests/golden_thing_admin_connection_test.cc 99.57% <100.00%> (+<0.01%) ⬆️
...or/integration_tests/golden/tests/plumbing_test.cc 93.54% <100.00%> (+0.44%) ⬆️
...le/cloud/internal/default_completion_queue_impl.cc 96.59% <0.00%> (-0.57%) ⬇️
...cloud/pubsub/internal/subscription_session_test.cc 97.98% <0.00%> (-0.51%) ⬇️
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4b06efd...c671b32. Read the comment docs.

@devbww devbww marked this pull request as ready for review July 27, 2022 21:53
@devbww devbww requested a review from a team July 27, 2022 21:53
@devbww devbww merged commit 9c813e1 into googleapis:main Jul 27, 2022
@devbww devbww deleted the internal-make-connection branch July 27, 2022 22:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@coryan coryan coryan approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@devbww @google-cloud-cpp-bot @coryan