fix(pubsub): missing subscription name in lease extensions#9523
Merged
coryan merged 1 commit intogoogleapis:mainfrom Jul 20, 2022
Merged
fix(pubsub): missing subscription name in lease extensions#9523coryan merged 1 commit intogoogleapis:mainfrom
coryan merged 1 commit intogoogleapis:mainfrom
Conversation
When I changed the lease extensions to use unary RPCs (as opposed to inline messages in the streaming pull), I neglected to include the subscription name with the request.
Contributor
|
Google Cloud Build Logs
ℹ️ NOTE: Kokoro logs are linked from "Details" below. |
dbolduc
approved these changes
Jul 19, 2022
Codecov Report
@@ Coverage Diff @@
## main #9523 +/- ##
==========================================
- Coverage 94.62% 94.61% -0.01%
==========================================
Files 1489 1489
Lines 137217 137218 +1
==========================================
- Hits 129837 129834 -3
- Misses 7380 7384 +4
Continue to review full report at Codecov.
|
coryan
added a commit
to coryan/google-cloud-cpp
that referenced
this pull request
Jul 20, 2022
…s#9523) When I changed the lease extensions to use unary RPCs (as opposed to inline messages in the streaming pull), I neglected to include the subscription name with the request.
coryan
added a commit
that referenced
this pull request
Jul 20, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When I changed the lease extensions to use unary RPCs (as opposed to
inline messages in the streaming pull), I neglected to include the
subscription name with the request.
This change is