Skip to content

feat(GCS+gRPC): implement PatchDefaultObjectAcl()#9487

Merged
coryan merged 1 commit intogoogleapis:mainfrom
coryan:feat-GCS+gRPC-implement-PatchDefaultObjectAcl
Jul 18, 2022
Merged

feat(GCS+gRPC): implement PatchDefaultObjectAcl()#9487
coryan merged 1 commit intogoogleapis:mainfrom
coryan:feat-GCS+gRPC-implement-PatchDefaultObjectAcl

Conversation

@coryan
Copy link
Copy Markdown
Contributor

@coryan coryan commented Jul 15, 2022

Fixes #4181


This change is Reviewable

@codecov
Copy link
Copy Markdown

codecov Bot commented Jul 15, 2022

Codecov Report

Merging #9487 (60354fb) into main (60354fb) will not change coverage.
The diff coverage is n/a.

❗ Current head 60354fb differs from pull request most recent head 02b500c. Consider uploading reports for the commit 02b500c to get more accurate results

@@           Coverage Diff           @@
##             main    #9487   +/-   ##
=======================================
  Coverage   94.64%   94.64%           
=======================================
  Files        1485     1485           
  Lines      137036   137036           
=======================================
  Hits       129695   129695           
  Misses       7341     7341           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 60354fb...02b500c. Read the comment docs.

@google-cloud-cpp-bot
Copy link
Copy Markdown
Contributor

Google Cloud Build Logs
For commit: 02b500ceb70a2c2b0971d7021467f4d5e09180f0

ℹ️ NOTE: Kokoro logs are linked from "Details" below.

@coryan coryan marked this pull request as ready for review July 15, 2022 18:11
@coryan coryan requested a review from a team July 15, 2022 18:11
@coryan
Copy link
Copy Markdown
Contributor Author

coryan commented Jul 16, 2022

/gcbrun

@google-cloud-cpp-bot
Copy link
Copy Markdown
Contributor

Google Cloud Build Logs
For commit: 02b500ceb70a2c2b0971d7021467f4d5e09180f0

ℹ️ NOTE: Kokoro logs are linked from "Details" below.

@coryan coryan enabled auto-merge (squash) July 16, 2022 15:53
@coryan coryan merged commit 76a4024 into googleapis:main Jul 18, 2022
@coryan coryan deleted the feat-GCS+gRPC-implement-PatchDefaultObjectAcl branch July 18, 2022 15:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Implement storage::GrpcClient::PatchDefaultObjectAcl

3 participants