ci(vcpkg): create lib/vcpkg.sh used by several builds#6701
Merged
devjgm merged 1 commit intogoogleapis:mainfrom Jun 5, 2021
Merged
ci(vcpkg): create lib/vcpkg.sh used by several builds#6701devjgm merged 1 commit intogoogleapis:mainfrom
devjgm merged 1 commit intogoogleapis:mainfrom
Conversation
Fixes: googleapis#6699 This PR factors the code to fetch the vcpkg repo into a library that's reused in a couple places. It also clones the repo at a recent release tag rather than cloning at HEAD which may break our builds and is not hermetic, or downloading a tarball, which lacks git history.
Contributor
|
Google Cloud Build Logs
ℹ️ NOTE: Kokoro logs are linked from "Details" below. |
Codecov Report
@@ Coverage Diff @@
## main #6701 +/- ##
=======================================
Coverage 95.69% 95.69%
=======================================
Files 1215 1215
Lines 112632 112632
=======================================
Hits 107784 107784
Misses 4848 4848 Continue to review full report at Codecov.
|
devbww
approved these changes
Jun 5, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #6699
This PR factors the code to fetch the vcpkg repo into a library that's
reused in a couple places. It also clones the repo at a recent release
tag rather than cloning at HEAD which may break our builds and is not
hermetic, or downloading a tarball, which lacks git history.
This change is