Skip to content

feat(storage): add DefaultObjectAccessControl CRUD and List for gRPC#5682

Merged
coryan merged 1 commit intogoogleapis:masterfrom
vnghia:grpc-bucket
Jan 6, 2021
Merged

feat(storage): add DefaultObjectAccessControl CRUD and List for gRPC#5682
coryan merged 1 commit intogoogleapis:masterfrom
vnghia:grpc-bucket

Conversation

@vnghia
Copy link
Copy Markdown
Contributor

@vnghia vnghia commented Jan 6, 2021 •
edited by coryan
Loading

@vnghia vnghia requested a review from a team January 6, 2021 14:26
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Jan 6, 2021
@product-auto-label product-auto-label Bot added the api: storage Issues related to the Cloud Storage API. label Jan 6, 2021
@coryan coryan added the kokoro:run Add this label to force Kokoro to re-run the tests. label Jan 6, 2021
@yoshi-kokoro yoshi-kokoro removed the kokoro:run Add this label to force Kokoro to re-run the tests. label Jan 6, 2021
@codecov
Copy link
Copy Markdown

codecov Bot commented Jan 6, 2021 •
edited
Loading

Codecov Report

Merging #5682 (1807195) into master (36bfcef) will increase coverage by 0.00%.
The diff coverage is 97.43%.

Impacted file tree graph

@@           Coverage Diff            @@
##           master    #5682    +/-   ##
========================================
  Coverage   95.42%   95.43%            
========================================
  Files        1107     1107            
  Lines      100775   100965   +190     
========================================
+ Hits        96166    96351   +185     
- Misses       4609     4614     +5
Impacted Files Coverage Δ
google/cloud/storage/internal/grpc_client.h 100.00% <ø> (ø)
...oogle/cloud/storage/tests/grpc_integration_test.cc 94.04% <88.09%> (-1.20%) ⬇️
google/cloud/storage/internal/grpc_client.cc 97.63% <100.00%> (+0.15%) ⬆️
...torage/internal/grpc_client_bucket_request_test.cc 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 36bfcef...1807195. Read the comment docs.

coryan
coryan approved these changes Jan 6, 2021
View reviewed changes
Copy link
Copy Markdown
Contributor

@coryan coryan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks!

@coryan coryan merged commit 50d6351 into googleapis:master Jan 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@coryan coryan coryan approved these changes

Assignees

No one assigned

Labels

api: storage Issues related to the Cloud Storage API. cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Milestone

No milestone

4 participants

@vnghia @coryan @googlebot @yoshi-kokoro