Skip to content

Enable google/cloud/asset #8145

@coryan

Description

@coryan

We cannot compile google/cloud/asset with protobuf <= 3.19.3 (current as-of 2022-01-28) because the protos define TRUE and FALSE as enums, while they are macros on macOS:

In file included from bazel-out/darwin-fastbuild/bin/external/com_google_googleapis/google/cloud/asset/v1/asset_service.pb.h:40:
bazel-out/darwin-fastbuild/bin/external/com_google_googleapis/google/cloud/asset/v1/assets.pb.h:4015:36: error: expected member name or ';' after declaration specifiers
  static constexpr EvaluationValue TRUE =
  ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ ^
/Applications/Xcode_12.0.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.15.sdk/usr/include/mach/boolean.h:81:17: note: expanded from macro 'TRUE'
#define TRUE    1
                ^

Metadata

Metadata

Assignees

No one assigned

    Labels

    api: cloudassetIssues related to the Cloud Asset Inventory API.externalThis issue is blocked on a bug with the actual product.type: cleanupAn internal cleanup or hygiene concern.

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions