feat: pass key sequence when creating key#397
Merged
Conversation
- with openssl3 keys are immutable - update to pass in keys in der format instead of mutating after creating key
|
If you have a moment, could you elaborate on how you construct the sequence here? I know so little about OpenSSL that I don't even know which docs to check. |
ariccio
added a commit
to ariccio/COVID-CO2-tracker
that referenced
this pull request
Sep 19, 2022
Trying patch for issue googleapis/google-auth-library-ruby#381, seems to work! googleapis/google-auth-library-ruby#397
Contributor
Author
|
Hi @ariccio, you may refer these docs for info on the structure of keys and more. RSA: https://www.rfc-editor.org/rfc/rfc3447#appendix-A |
dazuma
approved these changes
Oct 6, 2022
Contributor
dazuma
left a comment
There was a problem hiding this comment.
I added tests to verify the key contents, and updated the required tests to match the new CI matrix.
The code LGTM. Thanks Nivedha!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #381