Conversation
🤖 I have created a release *beep* *boop* --- ## [8.5.1](v8.5.0...v8.5.1) (2022-08-31) ### Bug Fixes * do not use #private ([#1454](#1454)) ([6c30274](6c30274)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
|
Oh that's interesting, private class fields have been on Node.js since v12. I believe this is more of a matter of reconfiguring our TypeScript compiler to a little more modern level of ECMAScript support rather than being an unsupported feature. That said, there's maybe an argument to be made on what is the more JS-idiommatic way of expressing the intent of a private method/property vs TS-idiommatic and I'm not sure where the collective consensus within the larger JavaScript ecosystem sits on that. Anyways just wanted to highlight that it might be possible to support |
|
@ruyadorno no problem, we just need to update gts & TypeScript in https://github.com/google/pack-n-play (the repo needs some love). |
|
a year after, this issue bothers me. 134 #private; Found 1 error.` |
|
@DesAWSume the error message explains what to do; simply target es2015+ in TypeScript: |
|
Oh~. 2nd look. I have a tsconfig under src folder, which my yarn build command will target to it. |
🤖 I have created a release *beep* *boop* --- ## [8.5.1](googleapis/google-auth-library-nodejs@v8.5.0...v8.5.1) (2022-08-31) ### Bug Fixes * do not use #private ([#1454](googleapis/google-auth-library-nodejs#1454)) ([6c30274](googleapis/google-auth-library-nodejs@6c30274)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
🤖 I have created a release *beep* *boop* --- ## [8.5.1](googleapis/google-auth-library-nodejs@v8.5.0...v8.5.1) (2022-08-31) ### Bug Fixes * do not use #private ([#1454](googleapis/google-auth-library-nodejs#1454)) ([6c30274](googleapis/google-auth-library-nodejs@6c30274)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
🤖 I have created a release *beep* *boop* --- ## [8.5.1](googleapis/google-auth-library-nodejs@v8.5.0...v8.5.1) (2022-08-31) ### Bug Fixes * do not use #private ([#1454](googleapis/google-auth-library-nodejs#1454)) ([6c30274](googleapis/google-auth-library-nodejs@6c30274)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
🤖 I have created a release *beep* *boop* --- ## [8.5.1](googleapis/google-auth-library-nodejs@v8.5.0...v8.5.1) (2022-08-31) ### Bug Fixes * do not use #private ([#1454](googleapis/google-auth-library-nodejs#1454)) ([6c30274](googleapis/google-auth-library-nodejs@6c30274)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
🤖 I have created a release *beep* *boop* --- ## [8.5.1](googleapis/google-auth-library-nodejs@v8.5.0...v8.5.1) (2022-08-31) ### Bug Fixes * do not use #private ([#1454](googleapis/google-auth-library-nodejs#1454)) ([6c30274](googleapis/google-auth-library-nodejs@6c30274)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Adding a
#private method is technically a breaking change. Our packing tests across all client libraries are now failing with(in CI, this looks like a
pack-n-playTypeScript test failure as a part of system tests)Let's not be that modern and use the regular private method instead.