Skip to content

fix: package.json sideEffects field should be a boolean#3428

Closed
blimmer wants to merge 3 commits intogoogleapis:mainfrom
blimmer:patch-1
Closed

fix: package.json sideEffects field should be a boolean#3428
blimmer wants to merge 3 commits intogoogleapis:mainfrom
blimmer:patch-1

Conversation

@blimmer
Copy link

@blimmer blimmer commented Feb 2, 2024 •
edited
Loading

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Resolves esbuild error:

▲ [WARNING] The value for "sideEffects" must be a boolean or an array [package.json]

    node_modules/googleapis/package.json:9:17:
      9 │   "sideEffects": "false",
        ╵                  ^

1 warning

Fixes #3419

Closes #2918 (should have been closed before)

@blimmer blimmer requested a review from a team as a code owner February 2, 2024 23:04
@google-cla
Copy link

google-cla bot commented Feb 2, 2024

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@product-auto-label product-auto-label bot added the size: xs Pull request size is extra small. label Feb 2, 2024
@sofisl sofisl mentioned this pull request Feb 9, 2024
Merged
@vdvleon
Copy link

vdvleon commented Feb 16, 2024

Any progress on this fix? I would love to have this 👼

@filipechagas filipechagas mentioned this pull request Feb 16, 2024
Closed
4 tasks
@konstrybakov
Copy link

konstrybakov commented Feb 19, 2024

+1

1 similar comment
@alexmcode
Copy link

alexmcode commented Feb 19, 2024

+1

gcf-merge-on-green bot pushed a commit that referenced this pull request Mar 12, 2024
@sofisl
fix: change packageJson sideEffects to boolean (#3435)
e9aabeb 
Moving #3428
@release-please release-please bot mentioned this pull request Mar 12, 2024
Merged
@sofisl sofisl closed this Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sofisl sofisl sofisl approved these changes

+1 more reviewer

@filipechagas filipechagas filipechagas approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

size: xs Pull request size is extra small.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Should sideEffects be boolean false ? esbuild is complaining about it since the 128.0.0 release: Add "sideEffects" to package.json

6 participants

@blimmer @vdvleon @konstrybakov @alexmcode @filipechagas @sofisl