Skip to content

feat(transport): add support for API keys for gprc#2326

Merged
quartzmo merged 2 commits intogoogleapis:mainfrom
julieqiu:auth
Jan 4, 2024
Merged

feat(transport): add support for API keys for gprc#2326
quartzmo merged 2 commits intogoogleapis:mainfrom
julieqiu:auth

Conversation

@julieqiu
Copy link
Copy Markdown
Member

@julieqiu julieqiu commented Dec 27, 2023

Fixes #485

@julieqiu julieqiu requested review from a team, codyoss and quartzmo December 27, 2023 20:51
@codyoss codyoss removed their request for review January 2, 2024 22:24
@codyoss
Copy link
Copy Markdown
Member

codyoss commented Jan 3, 2024

@quartzmo could you take a look at this

Copy link
Copy Markdown
Member

@quartzmo quartzmo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Thank you @julieqiu !!!

@quartzmo quartzmo enabled auto-merge (squash) January 4, 2024 19:25
@quartzmo quartzmo merged commit 9dbfb73 into googleapis:main Jan 4, 2024
codyoss added a commit to codyoss/google-cloud-go that referenced this pull request Jul 1, 2024
Porting googleapis/google-api-go-client#2326
which happened after we had made parity change to new auth lib.
codyoss added a commit to googleapis/google-cloud-go that referenced this pull request Jul 1, 2024
Porting googleapis/google-api-go-client#2326
which happened after we had made parity change to new auth lib.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

transport/grpc: support option.WithAPIKey

3 participants