Skip to content
This repository was archived by the owner on Nov 18, 2025. It is now read-only.

refactor(gax): use native AbortController#1788

Closed
MichaelDeBoey wants to merge 3 commits intogoogleapis:mainfrom
MichaelDeBoey:use-native-AbortController
Closed

refactor(gax): use native AbortController#1788
MichaelDeBoey wants to merge 3 commits intogoogleapis:mainfrom
MichaelDeBoey:use-native-AbortController

Conversation

@MichaelDeBoey
Copy link

@MichaelDeBoey MichaelDeBoey commented Aug 7, 2025 •
edited
Loading

AbortController is available as of Node v14.17.
Since we're supporting Node >= 18.0.0, we can safely remove the usage of abort-controller and go all-in on native functionality here

I'm sure people from the wider @e18e ecosystem cleanup (like @43081j, @benmccann, @Fuzzyma, @outslept & @talentlessguy) will be very happy to see these kind of changes as well

@MichaelDeBoey MichaelDeBoey requested a review from a team August 7, 2025 14:19
@MichaelDeBoey MichaelDeBoey requested a review from a team as a code owner August 7, 2025 14:19
@product-auto-label product-auto-label bot added the size: m Pull request size is medium. label Aug 7, 2025
@MichaelDeBoey MichaelDeBoey mentioned this pull request Aug 7, 2025
Open
sofisl
sofisl previously approved these changes Aug 7, 2025
View reviewed changes
@sofisl sofisl self-requested a review August 7, 2025 17:45
@v1rtl
Copy link

v1rtl commented Aug 7, 2025

Tests are failing at https://github.com/googleapis/gax-nodejs/actions/runs/16811797690/job/47619424733?pr=1788, it should be fixed first before getting merged

@MichaelDeBoey MichaelDeBoey force-pushed the use-native-AbortController branch from 260fe52 to 50e6ce7 Compare August 7, 2025 21:34
@MichaelDeBoey MichaelDeBoey force-pushed the use-native-AbortController branch from 50e6ce7 to 5189340 Compare August 7, 2025 21:38
@leahecole leahecole added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Aug 12, 2025
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Aug 12, 2025
@leahecole leahecole added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Aug 12, 2025
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Aug 12, 2025
@leahecole leahecole added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Aug 15, 2025
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Aug 15, 2025
@leahecole
Copy link
Contributor

leahecole commented Aug 15, 2025

the Browser test is still failing - PTAL! in case you're not able to see the logs, the error is

  Uncaught TypeError: Class extends value undefined is not a constructor or null
  at webpack://google-gax-browser-test/./node_modules/google-gax/build/src/streamArrayParser.js?:22:47
  
  TypeError: Class extends value undefined is not a constructor or null
      at eval (webpack://google-gax-browser-test/./node_modules/google-gax/build/src/streamArrayParser.js?:22:47)
      at ./node_modules/google-gax/build/src/streamArrayParser.js (/tmp/_karma_webpack_85601/commons.js:9561:1)
      at __webpack_require__ (/tmp/_karma_webpack_85601/runtime.js:31:42)
      at eval (webpack://google-gax-browser-test/./node_modules/google-gax/build/src/fallbackServiceStub.js?:54:29)
      at ./node_modules/google-gax/build/src/fallbackServiceStub.js (/tmp/_karma_webpack_85601/commons.js:9298:1)
      at __webpack_require__ (/tmp/_karma_webpack_85601/runtime.js:31:42)
      at eval (webpack://google-gax-browser-test/./node_modules/google-gax/build/src/fallback.js?:69:31)
      at ./node_modules/google-gax/build/src/fallback.js (/tmp/_karma_webpack_85601/commons.js:9276:1)
      at __webpack_require__ (/tmp/_karma_webpack_85601/runtime.js:31:42)
      at eval (webpack://google-gax-browser-test/./node_modules/google-gax/build/src/googleError.js?:55:20)

@leahecole leahecole added the needs work This is a pull request that needs a little love. label Aug 15, 2025
@sofisl
Copy link
Contributor

sofisl commented Sep 16, 2025

Closing due to inactivity

@sofisl sofisl closed this Sep 16, 2025
43081j added a commit to 43081j/gax-nodejs that referenced this pull request Sep 17, 2025
@43081j
perf: remove abort controller polyfill
c704b98 
All platforms support this now, so we don't need it anymore.

Replaces googleapis#1788.
@43081j 43081j mentioned this pull request Sep 17, 2025
Merged
6 tasks
@43081j
Copy link
Contributor

43081j commented Sep 17, 2025

Have recreated this and fixed CI in #1802

leahecole pushed a commit that referenced this pull request Sep 30, 2025
@43081j
perf: remove abort controller polyfill (#1802)
b2a8cec 
* perf: remove abort controller polyfill

All platforms support this now, so we don't need it anymore.

Replaces #1788.

* chore: run fix
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@sofisl sofisl sofisl approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

needs work This is a pull request that needs a little love. size: m Pull request size is medium.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@MichaelDeBoey @v1rtl @leahecole @sofisl @43081j @yoshi-kokoro