Conversation
|
When will this be included in a release? I see that both This makes the quantity of logs considerably increase, and brings a lot of noise... and additional costs for log storage. |
|
@sofisl @leahecole Any update on this fix? We also experiencing these massive logs in the latest library release and it is a dependency on multiple Firebase packages. |
|
Hi @flovouin and @aeri - thank you for commenting. I'm so sorry I missed the earlier GitHub comment - my github notifications are a mess and so the followup comment really helped. If you want to get the changes immediately and are able to take on a major version bump (requires Node 18+), there is an RC out for our 5.0.x version of gax that should encompass this PR. If you're getting gax as a dependency of one of the client libraries, please lmk which ones (I know I saw Firebase in there somewhere) so I can see what versions they are on. I am going to work with teammates to try to cut a patch release for 4.6.1 that only has this commit in it, but it requires some technical acrobatics to do safely so it may not be today (I want to get it done ASAP now that I know about it though and am doing the best I can to move it forwards within the constraints I have to work with!) |
|
@leahecole Thanks for your answer, right now I have them as a transitive dependency of: @google-cloud/firestore Currently it can be mitigated by performing a dependency override to a previous version like 4.3.3, however the list of dependent packages is much larger: https://www.npmjs.com/package/google-gax?activeTab=dependents |
|
Thank you for the info! Working on a 4.6.1, fighting my tools, but making forward progress. |
|
For pubsub, the |
|
4.6.1 is available on npm! https://www.npmjs.com/package/google-gax/v/4.6.1 🥳 |
|
Great!, thank you very much for providing a solution so quickly. Apparently some firestore libraries are already using the RC version as well. |
|
Perfect, thanks again for commenting so that it brought it to my attention! |
Some silly goose (me) accidentally left some debug statements in the pagination code so I'm cleaning them up! 🪿