This repository was archived by the owner on Nov 18, 2025. It is now read-only.
feat: Improve AuthClient Compatibility#1641
Merged
danielbankhead merged 7 commits intomainfrom Aug 27, 2024
Merged
Conversation
sofisl
approved these changes
Aug 27, 2024
Merged
danielbankhead
added a commit
that referenced
this pull request
Aug 28, 2024
This reverts commit 4edd33d.
danielbankhead
added a commit
that referenced
this pull request
Sep 9, 2024
)" This reverts commit d2648f0.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently
OAuth2ClientandJSONClientare the only supportedAuthClients, which can lead to issues in the future for those looking to use otherAuthClients. This PR opens the functionality up to otherAuthClients.This can be further cleaned up in the future with the following upstream FRs:
GoogleAuth<T>toAuthClientgoogle-auth-library-nodejs#1677🦕