This repository was archived by the owner on Nov 18, 2025. It is now read-only.
feat: use proto3 JSON serializer for REGAPIC workflows#1074
Merged
alexander-fenster merged 2 commits intomasterfrom Aug 5, 2021
Merged
feat: use proto3 JSON serializer for REGAPIC workflows#1074alexander-fenster merged 2 commits intomasterfrom
alexander-fenster merged 2 commits intomasterfrom
Conversation
c83887d to
d42a62b
Compare
summer-ji-eng
approved these changes
Aug 4, 2021
Contributor
|
Thank you so much for refactor the fallback.ts. |
gcf-merge-on-green bot
pushed a commit
that referenced
this pull request
Aug 5, 2021
🤖 I have created a release \*beep\* \*boop\* --- ## [2.22.0](https://www.github.com/googleapis/gax-nodejs/compare/v2.21.1...v2.22.0) (2021-08-05) ### Features * use proto3 JSON serializer for REGAPIC workflows ([#1074](https://www.github.com/googleapis/gax-nodejs/issues/1074)) ([6ef89f1](https://www.github.com/googleapis/gax-nodejs/commit/6ef89f16fdc3bb09200dc048b4fa5e15d265e973)) ### Bug Fixes * do not fail when decoding unknown error ([#1077](https://www.github.com/googleapis/gax-nodejs/issues/1077)) ([90e19b1](https://www.github.com/googleapis/gax-nodejs/commit/90e19b19b5d84430f929c4f510f4775344669a6b)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In this pull request, I'm adding a feature to use the new proto3 JSON serializer in REGAPIC workflows instead of
.toObjectand.fromObject, and also refactoring the very hard-to-readsrc/fallback.tsinto several files which now, I believe, have much more readable structure.In this PR, we:
.toProto3JSONand.fromProto3JSONinstead of.toObject/.fromObject, so we support all the fancy JSON serialization rules;fetchlogic into a separate file;There is almost no new code, the refactor is mostly the existing code moved around.
In general, I hope the new setup is more readable.