Skip to content
This repository was archived by the owner on Nov 18, 2025. It is now read-only.

feat: make OperationsClient closeable#1047

Merged
alexander-fenster merged 6 commits intogoogleapis:masterfrom
olavloite:operations-client-close
Jul 9, 2021
Merged

feat: make OperationsClient closeable#1047
alexander-fenster merged 6 commits intogoogleapis:masterfrom
olavloite:operations-client-close

Conversation

@olavloite
Copy link
Contributor

Adds a close function to the OperationsClient to close the underlying gRPC stub.

Towards https://github.com/googleapis/gapic-generator-typescript/issues/823 and googleapis/nodejs-spanner#1306

@olavloite olavloite requested a review from a team as a code owner July 2, 2021 09:02
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Jul 2, 2021
@olavloite
Copy link
Contributor Author

cc @skuruppu

@bcoe bcoe added the owlbot:run Add this label to trigger the Owlbot post processor. label Jul 2, 2021
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Jul 2, 2021
@alexander-fenster alexander-fenster changed the title fix: make OperationsClient closeable feat: make OperationsClient closeable Jul 9, 2021
@alexander-fenster alexander-fenster added the automerge Merge the pull request once unit tests and other checks pass. label Jul 9, 2021
@alexander-fenster alexander-fenster added the owlbot:run Add this label to trigger the Owlbot post processor. label Jul 9, 2021
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Jul 9, 2021
@alexander-fenster alexander-fenster merged commit 2dbba29 into googleapis:master Jul 9, 2021
@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label Jul 9, 2021
@olavloite olavloite deleted the operations-client-close branch July 10, 2021 07:50
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants