Skip to content
This repository was archived by the owner on Nov 18, 2025. It is now read-only.

perf: remove abort controller polyfill#1802

Merged
leahecole merged 2 commits intogoogleapis:mainfrom
43081j:abortless
Sep 30, 2025
Merged

perf: remove abort controller polyfill#1802
leahecole merged 2 commits intogoogleapis:mainfrom
43081j:abortless

Conversation

@43081j
Copy link
Contributor

@43081j 43081j commented Sep 17, 2025

All platforms support this now, so we don't need it anymore.

Replaces #1788.

Testing

  • Existing tests should cover this and have been updated

Checklist

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease
  • Appropriate docs were updated
  • Appropriate comments were added, particularly in complex areas or places that require background
  • No new warnings or issues will be generated from this change

@43081j
perf: remove abort controller polyfill
c704b98 
All platforms support this now, so we don't need it anymore.

Replaces googleapis#1788.
@43081j 43081j requested a review from a team September 17, 2025 08:52
@43081j 43081j requested a review from a team as a code owner September 17, 2025 08:52
@product-auto-label product-auto-label bot added the size: m Pull request size is medium. label Sep 17, 2025
@43081j 43081j mentioned this pull request Sep 17, 2025
Closed
@leahecole leahecole added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Sep 26, 2025
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Sep 26, 2025
@leahecole
Copy link
Contributor

leahecole commented Sep 29, 2025

@43081j thank you for this! Can you run npm run fix when you get a chance? Thank you!

@43081j
Copy link
Contributor Author

43081j commented Sep 29, 2025

should be done 👍

@leahecole leahecole added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Sep 30, 2025
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Sep 30, 2025
@leahecole leahecole added the owlbot:run Add this label to trigger the Owlbot post processor. label Sep 30, 2025
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Sep 30, 2025
@leahecole leahecole merged commit b2a8cec into googleapis:main Sep 30, 2025
29 of 32 checks passed
@release-please release-please bot mentioned this pull request Sep 30, 2025
Merged
@43081j 43081j deleted the abortless branch September 30, 2025 15:21
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

2 more reviewers

@leahecole leahecole leahecole approved these changes

@feywind feywind feywind approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

size: m Pull request size is medium.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@43081j @leahecole @feywind @yoshi-kokoro