Skip to content
This repository was archived by the owner on Nov 18, 2025. It is now read-only.

fix: remove debug statements#1692

Merged
sofisl merged 1 commit intomainfrom
cleanup
Jan 17, 2025
Merged

fix: remove debug statements#1692
sofisl merged 1 commit intomainfrom
cleanup

Conversation

@leahecole
Copy link
Contributor

Some silly goose (me) accidentally left some debug statements in the pagination code so I'm cleaning them up! 🪿

@leahecole leahecole requested a review from a team January 17, 2025 16:48
@leahecole leahecole requested a review from a team as a code owner January 17, 2025 16:48
@product-auto-label product-auto-label bot added the size: xs Pull request size is extra small. label Jan 17, 2025
@sofisl sofisl merged commit c7e0696 into main Jan 17, 2025
24 checks passed
@sofisl sofisl deleted the cleanup branch January 17, 2025 18:42
@flovouin
Copy link

When will this be included in a release?

I see that both 4.5.0 and 4.6.0 were released at the same time 3 days ago, although the GitHub release dates back to December, while this issue was fixed in January.

This makes the quantity of logs considerably increase, and brings a lot of noise... and additional costs for log storage.

@aeri
Copy link

aeri commented May 14, 2025

@sofisl @leahecole Any update on this fix? We also experiencing these massive logs in the latest library release and it is a dependency on multiple Firebase packages.

@leahecole leahecole self-assigned this May 14, 2025
@leahecole leahecole changed the title cleanup: remove debug statements fix: remove debug statements May 14, 2025
leahecole added a commit that referenced this pull request May 14, 2025
@leahecole
Copy link
Contributor Author

Hi @flovouin and @aeri - thank you for commenting. I'm so sorry I missed the earlier GitHub comment - my github notifications are a mess and so the followup comment really helped. If you want to get the changes immediately and are able to take on a major version bump (requires Node 18+), there is an RC out for our 5.0.x version of gax that should encompass this PR. If you're getting gax as a dependency of one of the client libraries, please lmk which ones (I know I saw Firebase in there somewhere) so I can see what versions they are on. I am going to work with teammates to try to cut a patch release for 4.6.1 that only has this commit in it, but it requires some technical acrobatics to do safely so it may not be today (I want to get it done ASAP now that I know about it though and am doing the best I can to move it forwards within the constraints I have to work with!)

@release-please release-please bot mentioned this pull request May 14, 2025
@aeri
Copy link

aeri commented May 14, 2025

@leahecole Thanks for your answer, right now I have them as a transitive dependency of:

@google-cloud/firestore
@google-cloud/pubsub

Currently it can be mitigated by performing a dependency override to a previous version like 4.3.3, however the list of dependent packages is much larger:

https://www.npmjs.com/package/google-gax?activeTab=dependents

@leahecole
Copy link
Contributor Author

Thank you for the info! Working on a 4.6.1, fighting my tools, but making forward progress.

@leahecole
Copy link
Contributor Author

For pubsub, the 5.0.0 version should have the fix because it's using the RC of gax, so if it's possible to use that, it will at least fix the problem there- I think firestore doesn't have it yet though but should soon, though if I can get that 4.6.1 for gax out the door it'll happen sooner than when they bump up to a new major of gax. thanks for the info and for bearing with me.

@leahecole
Copy link
Contributor Author

4.6.1 is available on npm! https://www.npmjs.com/package/google-gax/v/4.6.1 🥳

@aeri
Copy link

aeri commented May 19, 2025

Great!, thank you very much for providing a solution so quickly. Apparently some firestore libraries are already using the RC version as well.

@leahecole
Copy link
Contributor Author

Perfect, thanks again for commenting so that it brought it to my attention!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

size: xs Pull request size is extra small.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants