Skip to content
This repository was archived by the owner on Nov 18, 2025. It is now read-only.

fix: get rid of fs-extra#1418

Merged
alexander-fenster merged 4 commits intomainfrom
no-fs-extra
Feb 3, 2023
Merged

fix: get rid of fs-extra#1418
alexander-fenster merged 4 commits intomainfrom
no-fs-extra

Conversation

@alexander-fenster
Copy link
Contributor

We cannot use the new shiny recursive fs/promises methods such as fs.rm and fs.cp, but at least let's stop using fs-extra because we already import mkdirp, ncp, and rimraf, and that should be enough.

As soon as we drop Node 14, we'll drop these three as well.

@alexander-fenster alexander-fenster requested a review from a team as a code owner February 3, 2023 00:30
@alexander-fenster alexander-fenster requested a review from a team February 3, 2023 00:30
@product-auto-label product-auto-label bot added the size: s Pull request size is small. label Feb 3, 2023
@sofisl
Copy link
Contributor

sofisl commented Feb 3, 2023

Should we create an accompanying issue to drop the dependencies (maybe with DROP NODE 14 in the title so we remember)?

@alexander-fenster
Copy link
Contributor Author

@alexander-fenster
Copy link
Contributor Author

Oh no, rimraf v4 does not support Node 12 :) Rolling that part back.

@alexander-fenster alexander-fenster changed the title fix: get rid of fs-extra, upgrade rimraf fix: get rid of fs-extra Feb 3, 2023
@alexander-fenster alexander-fenster merged commit 082e006 into main Feb 3, 2023
@alexander-fenster alexander-fenster deleted the no-fs-extra branch February 3, 2023 02:24
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

size: s Pull request size is small.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants