feat(v2): add callctx telemetry helpers#472
Merged
quartzmo merged 4 commits intogoogleapis:mainfrom Mar 5, 2026
Merged
Conversation
Replace gRPC metadata Context management with new telemetry Context helpers.
quartzmo
added a commit
to quartzmo/gapic-generator-go
that referenced
this pull request
Mar 4, 2026
Replace gRPC metadata Context management with new telemetry Context helpers. refs: googleapis#1690 refs: googleapis/gax-go#472
shollyman
approved these changes
Mar 5, 2026
westarle
approved these changes
Mar 5, 2026
v2/callctx/callctx.go
Outdated
| // telemetryKey is a private type used to store/retrieve telemetry context values. | ||
| type telemetryKey string | ||
|
|
||
| // WithTelemetryContext injects telemetry attributes values (like resource name |
Contributor
There was a problem hiding this comment.
nit
Suggested change
| // WithTelemetryContext injects telemetry attributes values (like resource name | |
| // WithTelemetryContext injects telemetry attribute values (like resource name |
Member
Author
Because the Go context package deliberately hides its internal state and does not provide an iterator or reflection mechanism over its linked list of values, we cannot inspect the context to see what other keys might be present. We can only test for specific keys. |
quartzmo
added a commit
to quartzmo/google-cloud-go
that referenced
this pull request
Mar 5, 2026
Enable grpctransport and httptransport to inject static attributes, capture dynamic attributes from context, and enforce error semantics. refs: googleapis/gax-go#472 refs: googleapis/gapic-generator-go#1706
quartzmo
added a commit
to quartzmo/google-cloud-go
that referenced
this pull request
Mar 5, 2026
Enable grpctransport and httptransport to inject static attributes, capture dynamic attributes from context, and enforce error semantics. refs: googleapis/gax-go#472 refs: googleapis/gapic-generator-go#1706
quartzmo
added a commit
to quartzmo/google-cloud-go
that referenced
this pull request
Mar 5, 2026
Enable grpctransport and httptransport to inject static attributes, capture dynamic attributes from context, and enforce error semantics. refs: googleapis/gax-go#472 refs: googleapis/gapic-generator-go#1706
quartzmo
added a commit
to quartzmo/google-cloud-go
that referenced
this pull request
Mar 5, 2026
Enable grpctransport and httptransport to inject static attributes, capture dynamic attributes from context, and enforce error semantics. refs: googleapis/gax-go#472 refs: googleapis/gapic-generator-go#1706
quartzmo
added a commit
to googleapis/google-cloud-go
that referenced
this pull request
Mar 12, 2026
…14133) Enable grpctransport and httptransport to inject static attributes, capture dynamic attributes from context, and enforce error semantics. refs: googleapis/gax-go#472 refs: googleapis/gapic-generator-go#1706
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace gRPC metadata Context management with new telemetry Context helpers.