chore(cmd,server,util): replace use of github.com/golang/protobuf/proto#1534
Merged
julieqiu merged 2 commits intogoogleapis:mainfrom Aug 19, 2024
Merged
chore(cmd,server,util): replace use of github.com/golang/protobuf/proto#1534julieqiu merged 2 commits intogoogleapis:mainfrom
julieqiu merged 2 commits intogoogleapis:mainfrom
Conversation
Use google.golang.org/protobuf/proto instead. Per staticcheck: "github.com/golang/protobuf/proto" is deprecated: Use the "google.golang.org/protobuf/proto" package instead. (SA1019)
Member
|
@julieqiu are we still retaining some refs here? I would have expected the go.mod to have an update to remove the direct dep too. |
Member
Author
|
@codyoss - I only did github.com/golang/protobuf/proto in this CL, not the entire github.com/golang/protobuf module. |
codyoss
approved these changes
Aug 19, 2024
codyoss
added a commit
that referenced
this pull request
Dec 3, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1525