This repository was archived by the owner on Jan 18, 2026. It is now read-only.
feat: TypeScript microgenerator#9
Merged
alexander-fenster merged 73 commits intomasterfrom Aug 26, 2019
Merged
Conversation
Call method without arguments or empty object
Contributor
Author
|
To be updated: |
JustinBeckwith
suggested changes
Aug 23, 2019
Contributor
JustinBeckwith
left a comment
There was a problem hiding this comment.
First round done. Space key entering . random . dots, so sorry about that.
Contributor
Author
|
@xiaozhenliu-gg5 Please feel free to merge this after the last comments are resolved. Thanks! |
| and authenticaion providers, allowing you to describe what your services | ||
| expect and accept from clients. | ||
|
|
||
| ## api-compiler |
Contributor
Author
There was a problem hiding this comment.
The whole protos folder is not supposed to be here, it will go away after the next gax release. #13
lukesneeringer
approved these changes
Aug 24, 2019
Contributor
lukesneeringer
left a comment
There was a problem hiding this comment.
Approved with nits.
Co-Authored-By: Luke Sneeringer <lukesneeringer@google.com>
Co-Authored-By: Luke Sneeringer <lukesneeringer@google.com>
xiaozhenliu-gg5
approved these changes
Aug 26, 2019
Contributor
xiaozhenliu-gg5
left a comment
There was a problem hiding this comment.
@alex, sure, I will merge the PR when it gets all approvals.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Initial commit, work in progress. Works as a
protocplugin. Generates regular (unary) methods only.(just moving the development from
proof-of-conceptbranch tomasterbranch since we now have CI and baseline tests!)Attn. reviewers: please pay attention on the generator code and not the library template that will change soon to backport the recent gapic-generator changes.