Skip to content
This repository was archived by the owner on Feb 15, 2026. It is now read-only.

feat: include google/protobuf/compiler#213

Merged
alexander-fenster merged 1 commit intomasterfrom
include-compiler
Aug 23, 2019
Merged

feat: include google/protobuf/compiler#213
alexander-fenster merged 1 commit intomasterfrom
include-compiler

Conversation

@alexander-fenster
Copy link
Contributor

@alexander-fenster alexander-fenster commented Aug 22, 2019

Long story short:

  • gax uses this package offline to get the proto files from it;
  • TypeScript micro-generator wants to take proto files from gax instead of having its own copy
  • TypeScript micro-generator needs to have google/protobuf/compiler

So here we go!

  • Tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Aug 22, 2019
@alexander-fenster alexander-fenster mentioned this pull request Aug 23, 2019
Merged
@alexander-fenster alexander-fenster merged commit 79ce071 into master Aug 23, 2019
@alexander-fenster alexander-fenster deleted the include-compiler branch August 23, 2019 01:24
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@JustinBeckwith JustinBeckwith Awaiting requested review from JustinBeckwith

@callmehiphop callmehiphop Awaiting requested review from callmehiphop

@stephenplusplus stephenplusplus Awaiting requested review from stephenplusplus

1 more reviewer

@bcoe bcoe bcoe approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@alexander-fenster @bcoe @googlebot