This repository was archived by the owner on Jan 18, 2026. It is now read-only.
feat: add dynamic routing to generated client#1042
Merged
alicejli merged 10 commits intogoogleapis:mainfrom Nov 8, 2021
Merged
feat: add dynamic routing to generated client#1042alicejli merged 10 commits intogoogleapis:mainfrom
alicejli merged 10 commits intogoogleapis:mainfrom
Conversation
|
Here is the summary of changes. You are about to add 3 region tags.
This comment is generated by snippet-bot.
|
summer-ji-eng
approved these changes
Nov 3, 2021
Contributor
summer-ji-eng
left a comment
There was a problem hiding this comment.
Thank you Alice with strong test cases. Overall looks good to me.
I have some suggestions on simplifying the logic of dynamic routing request parameters.
Let me know if it make sense to you.
😄
gcf-merge-on-green bot
pushed a commit
that referenced
this pull request
Nov 8, 2021
🤖 I have created a release \*beep\* \*boop\* --- ## [2.10.0](https://www.github.com/googleapis/gapic-generator-typescript/compare/v2.9.0...v2.10.0) (2021-11-08) ### Features * add dynamic routing to generated client ([#1042](https://www.github.com/googleapis/gapic-generator-typescript/issues/1042)) ([afe38bf](https://www.github.com/googleapis/gapic-generator-typescript/commit/afe38bf0b36e50240684e3806f7505c009611a3f)) ### Bug Fixes * naming collision on samples ([#1034](https://www.github.com/googleapis/gapic-generator-typescript/issues/1034)) ([b1e522e](https://www.github.com/googleapis/gapic-generator-typescript/commit/b1e522e3f6b65766836db9f12a00bf531d71ed35)) * remove deprecated fields ([#1036](https://www.github.com/googleapis/gapic-generator-typescript/issues/1036)) ([dcdb895](https://www.github.com/googleapis/gapic-generator-typescript/commit/dcdb89599857db1715be3438a0a571ff3b05d6ce)) * replace empty objects with curly brackets instead of strings ([#1041](https://www.github.com/googleapis/gapic-generator-typescript/issues/1041)) ([b6c3957](https://www.github.com/googleapis/gapic-generator-typescript/commit/b6c395725d7b0d01e0dbed211fafbaf5764f4171)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Breaking up #1007 into 2 different PRs for ease of review. This is the second part that adds the dynamic routing header into the generated client.
First part: #1028
For issue: googleapis/google-cloud-node-core#584